Updated DOH Travel Pass Aid `Description` by adding a missing semicolon `;` to separate the `Cyclic` and `Linear` File IDs.
Signed-off-by: ry4000 <154689120+ry4000@users.noreply.github.com>
**Added Public Transport AIDs**
- DOH Travel Pass
- JFK OMNY
**Updated dormakaba AID**
- Updated dormakaba mobile access `Vendor`, `Name`, and `Description`
- Moved AID from `Transport` to `PACS` section
Signed-off-by: ry4000 <154689120+ry4000@users.noreply.github.com>
Most prominent one was "lf pac clone --cn 123456789" causing garbage on the terminal
Some changed code was valid before but as ppl tend to copy-paste to new code,
better to uniformize and document usages of CLIGetStrWithReturn.
Exceptions left are when filling real buffers (bin, raw,...), not strings.
1- Inlined functions related to hf iclass legrec within util.c for marginal performance gains.
2- Fixed bug preventing errors to be displayed properly and the process from interrupting on an error or on completion.
3- Fixed code indentation of the while loop in iclass.c
4- Fixed bug in the while cycle (was missing index++)
5- Improved ways to display hex results by using dbhexdump
**Re-Added Gallagher AIDs**
- The alternative endian Gallagher AIDs have been re-added out of an abundance of caution.
**Added Transact Campus AIDs**
- The AIDs were retrieved from an Institution's Guest Card via NXP TagInfo and PM3; a Google search revealed that `Transact Card, Inc.` are the ID Card provider for said Institution, so the Institution has not been explicitly named.
Signed-off-by: ry4000 <154689120+ry4000@users.noreply.github.com>
Made multiple changes as per iceman's comments.
Removed redundant/unused function i forgot into cmdhficlass.c
Moved conversion functions in util.c for now but haven't yet check if it's possible to reuse the current fuctions already there. Will do that in a moment.
Based on the work described in Dismantling iClass whitepaper.
hf iclass legbrute is tested working
hf iclass legrec is partially working: logic of operations and sequence seems to be in order and was tested on simulated data to be effective. The privilege escalation part is still not successful, but the logic should be correct.
Philippe Teuwen