dandri/pyxis
1
0
Fork 0
mirror of https://github.com/torlando-tech/pyxis.git synced 2026-08-27 21:19:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: scope LVGL lock to the snapshot in T:SCREENSHOT (not the serial dump)

Browse Source 
LVGL_LOCK() was held for the entire base64 serial dump (~18s for a 320x240
frame), blocking the LVGL render task the whole time and tripping the 5s
LVGLLock recursive-take timeout assert in debug builds (crash on every
screenshot). lv_snapshot_take() copies the pixels into its own buffer, so the
lock is only needed for the snapshot itself -- scope it there, dump the copy
unlocked, and re-take the lock only to free the snapshot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWZuYkHBRqNb6BZHV8sTG5
This commit is contained in:
torlando-agent[bot]
2026-06-19 10:53:33 -04:00
co-authored by Claude Opus 4.8
parent a1c548dbf2
commit 4dc5c89e25
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main.cpp
+16 -8
View File
@@ -2086,15 +2086,23 @@ static void handle_test_hook_command(const String& line) {
// all lines between the markers, base64-decodes, and converts
// to PNG. FMT carries the byte order (`be` when LV_COLOR_16_SWAP
// is on, `le` otherwise) so the decoder doesn't have to guess.
LVGL_LOCK();
lv_obj_t* scr = lv_scr_act();
if (!scr) {
Serial.println("T:ERR no active screen");
return;
// Hold the LVGL lock ONLY for the snapshot: lv_snapshot_take() copies
// the screen pixels into a freshly-allocated buffer, so live LVGL state
// isn't touched during the ~18s base64 serial dump below. Holding the
// recursive mutex across the whole dump blocks the LVGL render task and
// trips the 5s LVGLLock timeout assert (LVGLLock.h) in debug builds.
lv_img_dsc_t* snap = nullptr;
{
LVGL_LOCK();
lv_obj_t* scr = lv_scr_act();
if (!scr) {
Serial.println("T:ERR no active screen");
return;
}
snap = lv_snapshot_take(scr, LV_IMG_CF_TRUE_COLOR);
}
lv_img_dsc_t* snap = lv_snapshot_take(scr, LV_IMG_CF_TRUE_COLOR);
if (!snap || !snap->data) {
if (snap) lv_snapshot_free(snap);
if (snap) { LVGL_LOCK(); lv_snapshot_free(snap); }
Serial.println("T:ERR snapshot failed (PSRAM exhausted?)");
return;
}
@@ -2150,7 +2158,7 @@ static void handle_test_hook_command(const String& line) {
Serial.println(line);
}
Serial.println("T:SCREENSHOT END");
lv_snapshot_free(snap);
{ LVGL_LOCK(); lv_snapshot_free(snap); }
}
else if (cmd == "T:CALL_INJECT") {
// T:CALL_INJECT <on|off> [freq_hz] [amp_pct]