Greptile review feedback on PR #21: ACCEPT: - test_patch_nimble.py:151 (P1) — replace dead `if False else True` ternary with a real assertion that "already applied" is absent on the first run. - test_patch_nimble.py:247 (P1) — invoke the shim subprocess via `sys.executable` instead of hardcoded `/usr/bin/python3` so CI's setup-python interpreter is used consistently. - workflows/test.yml:50 (P2) — include hash of deps/microReticulum/platformio.ini in PlatformIO cache key so the cache invalidates when dependencies change. MODIFY (narrowed): - test_ring_buffers.cpp:209 (P2) — keep both `write(data, 0)` and `write(data, -1)` assertions, but add a comment clarifying that EncodedRingBuffer::write() takes signed `int length` (not size_t), so -1 hits the `length <= 0` branch — same as 0. Greptile's premise (size_t wrap to SIZE_MAX) does not apply to this codebase. The two assertions lock the contract in case the param is ever migrated to size_t. REJECT (silently — no public reply per agent policy): - test_audio_filters.cpp:237 (P1) — VoiceFilterChain::process() takes `numSamples = frames * channels` per the documented contract in audio_filters.h:33-40, and the implementation does `numFrames = numSamples / channels_` (audio_filters.cpp:63). The multichannel test correctly passes `(int)samples.size() = 8000` (4000 frames * 2 channels). No out-of-bounds read occurs.
Pyxis Tests
Three test surfaces, each runnable independently.
1. Pyxis-unique pytest suite
Native C++ tests of pyxis-unique code (BLE fragmenter, HDLC, etc.) and Python tests of build scripts.
/usr/bin/python3 -m pytest tests/build_scripts tests/native -v
System Python 3.9 has pytest pre-installed; Homebrew Python does not.
build_scripts/test_patch_nimble.py— verifiespatch_nimble.pyidempotency, drift detection, missing-file handlingnative/test_hdlc.{cpp,py}— HDLC escape/unescape/frame round-trip + golden vector against Python RNSnative/test_ble_fragmenter.{cpp,py}— BLEFragmenter ↔ BLEReassembler: in-order, out-of-order, duplicate, dropped+timeout, per-peer isolation, MTU changenative/test_ble_peer_manager.{cpp,py}— connection-map state machine: discover, identity promotion, blacklist, handle map cleanup, MAC rotation, pool exhaustionnative/test_ble_operation_queue.{cpp,py}— GATT op queue: FIFO, busy-state, timeout, clearForConnection, buildernative/test_ring_buffers.{cpp,py}— PCM + encoded SPSC ring buffers, including 100k-frame multithreaded producer/consumer stressnative/test_audio_filters.{cpp,py}— VoiceFilterChain frequency response, peak limiting, multichannel
Adding a new native C++ test
Pattern: pure C++ unit + thin pytest wrapper.
- Write
tests/native/test_<thing>.cpp— include from../../{src,lib/...}for the unit under test, use the existingEXPECT_EQ/EXPECT_TRUE/RUN(name)framework, return non-zero on any failure. - If the unit pulls in microReticulum types, the shims in
tests/native/cover what's been needed so far:Bytes.h→bytes_shim.h(minimalRNS::Bytes— append/data/size/writable/resize/mid)Log.h(no-opTRACE/WARNING/INFO/ERRORmacros)Utilities/OS.h(OS::time()withset_fake_time()/clear_fake_time())
- Write
tests/native/test_<thing>.py— copy thetest_hdlc.pytemplate, swap source/include paths, run. - Confirm:
/usr/bin/python3 -m pytest tests/native/test_<thing>.py -v
2. LXST audio interop tests
Python tests verifying wire format and codec compatibility between pyxis (C++), Python LXST, and LXST-kt (Kotlin).
/usr/bin/python3 -m pytest tests/interop -v
Requires pycodec2 and access to $HOME/repos/public/LXST.
3. microReticulum native unit tests (PlatformIO)
The fork's microReticulum tests live under deps/microReticulum/test/ and run via PlatformIO Unity.
cd deps/microReticulum && pio test -e native17
Use native17, not native — the C++11 env is broken (static-constexpr ODR-use). Baseline as of 2026-05-02: 94/114 PASS, 7 FAIL, 5 SKIPPED, 7 suites ERRORED. The clean suites are
test_os, test_bytes, test_msgpack, test_crypto, test_filesystem, test_objects, test_interop, test_general, test_reference, test_example, test_collections.