From 5075837d555bc8f215d1eaacbc1b4efb6ee705e8 Mon Sep 17 00:00:00 2001
From: Rory& <root@rory.gay>
Date: Tue, 2 Dec 2025 18:06:00 +0100
Subject: [PATCH] Support deleting ACKs for type==channel

---
 assets/openapi.json                           | Bin 838770 -> 846348 bytes
 assets/schemas.json                           | Bin 370798 -> 371447 bytes
 .../channels/#channel_id/messages/index.ts    |  29 ++++++++++++++++--
 .../uncategorised/MessageAcknowledgeSchema.ts |  22 ++++++++++++-
 4 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/assets/openapi.json b/assets/openapi.json
index d20ef2fb821c7ee070ac20f9dcab09e5f14162a9..5a81a5de18637ca013d622eaaeb535a012e19b73 100644
GIT binary patch
delta 544
zcmew~!?@>)aYGB^7ADsX(>JVTQ=RO<VK-SnqG;MZX4dKL8<=izJ0@r6<(KEArlhA%
z*K=Ubm_F|XGuLzlQ6{$OJB68KrZ0$OQJX$NkyU)Ufg2;o<O^}N)Ad&~3xar@(+#wk
zq^BQP&B{OhLJYU)WCwnU$rF4zCa<${p6(FJC^S7`6_fn*4O^L6+tW5O0WmWWvj8#c
z_Oy*`A}nl~d1aX;snZ=dvgx*0ZDreDwUzzPNg<F}v3@l~GCny!C3U)@5{J%qhi7ck
zjMER?;GVGEU=sTyMs}!*=?5RONKbc&W@Vf1(9Cg$6{J6Yx`H5Q-1LMR7LMs(12`0>
ze^|;RFnxm>kK}X#ZVnN?&|ueiU&r9!cu&7D&yeXG12|`G7vNx*gqq)A!8L(#`-Xn5
za>nf!syTm?W><p(BmeYxW=@&y3wqe+B8)6zCc(*O)2$mhc&CS6V;7qK;0@Qj=?0<f
z$EQ!=W@VXvzLmqi9ViRLoZGD%xqP2aFHm6>nI6Z?DZ4$PfhUiV3lXc^4Kuiz7`H1h
Xaf>od-{8Z|+1`=Hy}cui=T#~ItVF|N

delta 118
zcmeCVV*F`_aYGB^7ADsX(*^D_+D=Z;WSK6vk?H321^1cQ+r73h0WmWWvj8#ccCRgL
zA}s9_cd%`rxP$%A$?1HvIJl=Dd&ea-y<iH@{^<gD*q2S0XJ+M@zG5DSc{|T64j|^-
U&NGY4_i4LQ3-@-V7M@qB05_2@0{{R3

diff --git a/assets/schemas.json b/assets/schemas.json
index bfe3de68cd04aef4b2ca8e47582bcaec55e4566b..e092a919f7cd67bbb07f6f870207521398bc395e 100644
GIT binary patch
delta 124
zcmaENLG1fgv4$4LEli8Nr_bNOBs*Ooi%D<#0)FP8?dQFjm>9Vole6>k%X3mw(o?6s
zWDJ<T?=Yjl^y~4AqG08dC-{|2f33vKIo->ZNoBHvkmz)QZ;S$y_j}4rFZj<KHTgiX
a!}R}cEFA4OeVBll8Hic7-}GUf8VvyHpD^_R

delta 46
zcmex<RqWjbv4$4LEli8NCm(3k-EQy0#Kbs#-vkzp_9TBMAZ7+)mhDOYtW%=_&PNfZ

diff --git a/src/api/routes/channels/#channel_id/messages/index.ts b/src/api/routes/channels/#channel_id/messages/index.ts
index d399e53af..8790241d8 100644
--- a/src/api/routes/channels/#channel_id/messages/index.ts
+++ b/src/api/routes/channels/#channel_id/messages/index.ts
@@ -18,7 +18,6 @@
 
 import { handleMessage, postHandleMessage, route } from "@spacebar/api";
 import {
-	ApiError,
 	Attachment,
 	AutomodRule,
 	AutomodTriggerTypes,
@@ -39,9 +38,9 @@ import {
 	Relationship,
 	Rights,
 	Snowflake,
+	stringGlobToRegexp,
 	uploadFile,
 	User,
-	stringGlobToRegexp,
 } from "@spacebar/util";
 import { Request, Response, Router } from "express";
 import { HTTPError } from "lambert-server";
@@ -49,6 +48,7 @@ import multer from "multer";
 import { FindManyOptions, FindOperator, LessThan, MoreThan, MoreThanOrEqual } from "typeorm";
 import { URL } from "url";
 import {
+	AcknowledgeDeleteSchema,
 	AutomodCustomWordsRule,
 	AutomodRuleActionType,
 	AutomodRuleEventType,
@@ -57,6 +57,7 @@ import {
 	MessageCreateCloudAttachment,
 	MessageCreateSchema,
 	Reaction,
+	ReadStateType,
 	RelationshipType,
 } from "@spacebar/schemas";
 
@@ -532,4 +533,28 @@ router.post(
 	},
 );
 
+router.delete(
+	"/ack",
+	route({
+		requestBody: "AcknowledgeDeleteSchema",
+		responses: {
+			204: {},
+		},
+	}),
+	async (req: Request, res: Response) => {
+		const { channel_id } = req.params; // not really a channel id if read_state_type != CHANNEL
+		const body = req.body as AcknowledgeDeleteSchema;
+		if (body.version != 2) return res.status(204).send();
+		// TODO: handle other read state types
+		if (body.read_state_type != ReadStateType.CHANNEL) return res.status(204).send();
+
+		const readState = await ReadState.findOne({where: {channel_id}});
+		if (readState) {
+			await readState.remove();
+		}
+
+		res.status(204).send();
+	},
+);
+
 export default router;
diff --git a/src/schemas/uncategorised/MessageAcknowledgeSchema.ts b/src/schemas/uncategorised/MessageAcknowledgeSchema.ts
index 3ba716491..891ccc903 100644
--- a/src/schemas/uncategorised/MessageAcknowledgeSchema.ts
+++ b/src/schemas/uncategorised/MessageAcknowledgeSchema.ts
@@ -19,7 +19,27 @@
 export interface MessageAcknowledgeSchema {
 	manual?: boolean;
 	mention_count?: number;
-	flags?: number;
+	flags?: ReadStateFlags;
 	last_viewed?: number;
 	token?: string;
 }
+
+export interface AcknowledgeDeleteSchema {
+	read_state_type?: ReadStateType;
+	version?: number;
+}
+
+export enum ReadStateType {
+	CHANNEL = 0,
+	GUILD_EVENT = 1,
+	NOTIFICATION_CENTER = 2,
+	GUILD_HOME = 3,
+	GUILD_ONBOARDING_QUESTION = 4,
+	MESSAGE_REQUESTS = 5,
+}
+
+export enum ReadStateFlags {
+	IS_GUILD_CHANNEL = 1 << 0,
+	IS_THREAD = 1 << 1,
+	IS_MENTION_LOW_IMPORTANCE = 1 << 2,
+}
\ No newline at end of file