Don't allow message types to be edited

This commit is contained in:
Madeline
2023-02-03 14:39:42 +11:00
parent df199227f8
commit 583b271ba2
4 changed files with 25 additions and 6 deletions
@@ -30,6 +30,7 @@ import {
Snowflake,
uploadFile,
MessageCreateSchema,
MessageEditSchema,
} from "@fosscord/util";
import { Router, Response, Request } from "express";
import multer from "multer";
@@ -52,13 +53,13 @@ const messageUpload = multer({
router.patch(
"/",
route({
body: "MessageCreateSchema",
body: "MessageEditSchema",
permission: "SEND_MESSAGES",
right: "SEND_MESSAGES",
}),
async (req: Request, res: Response) => {
const { message_id, channel_id } = req.params;
let body = req.body as MessageCreateSchema;
let body = req.body as MessageEditSchema;
const message = await Message.findOneOrFail({
where: { id: message_id, channel_id },
@@ -81,10 +82,6 @@ router.patch(
}
} else rights.hasThrow("SELF_EDIT_MESSAGES");
// The permision should obviously not allow editing the message type
// But for people with the right, does this make sense?
if (body.type) rights.hasThrow("MANAGE_MESSAGES");
const new_message = await handleMessage({
...message,
// TODO: should message_reference be overridable?