Clean up some types

This commit is contained in:
Rory&
2026-07-31 18:20:14 +02:00
parent 4f3ae52c73
commit b3427f9896
6 changed files with 61 additions and 17 deletions
+3 -5
View File
@@ -21,7 +21,7 @@ import path from "node:path";
import { Request, Response, Router } from "express";
import { HTTPError } from "lambert-server/HTTPError";
import { route } from "@spacebar/api/middlewares";
import { ReportMenuType, ReportMenuTypeNames, CreateReportSchema } from "@spacebar/schemas";
import { ReportMenuTypeNames, ReportMenuType, type CreateReportSchema, ReportMenuTypeNameArray } from "@spacebar/schemas";
import { FieldErrors } from "@spacebar/util";
const router = Router({ mergeParams: true });
@@ -32,7 +32,7 @@ router.get(
description: "[EXT] Get available reporting menu types.",
responses: {
200: {
body: "Array<ReportMenuTypeNames>",
body: "ReportMenuTypeNames",
},
},
}),
@@ -161,9 +161,7 @@ for (const type of Object.values(ReportMenuTypeNames)) {
);
};
const t = Number(Object.entries(ReportMenuTypeNames).find((x) => x[1] === type)?.[0]) as ReportMenuType;
// TODO: did i miss anything?
switch (t) {
switch (type) {
case ReportMenuType.GUILD:
case ReportMenuType.GUILD_DISCOVERY:
requireFields(body, ["guild_id"]);
@@ -23,7 +23,7 @@ import { route } from "@spacebar/api/middlewares";
import { Webhook, Message } from "@spacebar/database";
import { Config, DiscordApiErrors, emitEvent, handleFile, ValidateName, WebhooksUpdateEvent } from "@spacebar/util";
import { executeWebhook } from "@spacebar/api/util/handlers/Webhook";
import { WebhookResponse, WebhookUpdateSchema } from "@spacebar/schemas";
import type { WebhookResponse, WebhookUpdateSchema } from "@spacebar/schemas";
const router = Router({ mergeParams: true });
+1 -1
View File
@@ -22,7 +22,7 @@ import { In } from "typeorm";
import { route } from "@spacebar/api/middlewares";
import { Webhook, Channel, Message } from "@spacebar/database";
import { Config, DiscordApiErrors, getPermission, WebhooksUpdateEvent, emitEvent, handleFile, ValidateName, MessageDeleteBulkEvent } from "@spacebar/util";
import { WebhookResponse, WebhookUpdateSchema } from "@spacebar/schemas";
import type { WebhookResponse, WebhookUpdateSchema } from "@spacebar/schemas";
const router = Router({ mergeParams: true });