From c8af1e125fc67074bd549f4fdbd96b6c77dc518c Mon Sep 17 00:00:00 2001
From: Rory& <root@rory.gay>
Date: Sat, 14 Mar 2026 06:01:48 +0100
Subject: [PATCH] Remove array global pollution

---
 assets/openapi.json                    | Bin 963624 -> 963479 bytes
 assets/schemas.json                    | Bin 426526 -> 426405 bytes
 src/util/entities/Channel.ts           |   5 +++--
 src/util/util/extensions/Array.test.ts |   9 ---------
 src/util/util/extensions/Array.ts      |  10 ----------
 5 files changed, 3 insertions(+), 21 deletions(-)
 delete mode 100644 src/util/util/extensions/Array.test.ts

diff --git a/assets/openapi.json b/assets/openapi.json
index 85292bc338782531e0d4db1501f4b4fbd9870c5f..13e0249ab1ea061462b21247648e7a47963babe2 100644
GIT binary patch
delta 1381
zcmZ`&OGs2<6z1Of&%HBu92*xoFU!$HA|f9>7G^$bkr|O18f4ah8%J}Pg@qYYLxCeb
zXz13QHiBeXM5SqU76s}?vM_^$s6{FzxrnS)QbGN9Kqc<q;)BaQ-+#{ezH`o<`6B#W
z6n!M6HRIWFH4~k4N)tM7vis;<1UHtRRvU0r1Iy9F8;UXW2>@jtlZJg#zFr>m#1>-`
zhfIqx%kP&f35X}qBq<-udm%GXp|~(_r&^r2E%|U{ShkX{j&-{QbSVfP>^aCZENcT7
zR*fnQr)$|}EPE<38V<8*5WHG0QratLQ&&5?=QFd6c4_(=yX!E=upq+ge(O;b48&zd
zCAZj(Tr-WQaAVat1G+rHW;HVbtGCD=^1WxrGXz1S$WZ)hh6N|Hz=y40n48Z3VsGsN
zE;qtU4jYW53xdmf<8!c<o9d;BEchtUWoX8*O$7=RKvT9kRg%DG*oZSNDOL=3N_LEQ
zNs(mIXdR>}<~K=^xNr!pI!w6mEC0YxC9)qcMW6<IY;XXhyDf}19)(?2^K;_TLN@b%
zG$iZ$N4<$kHJbzIa2u>s1;pgA{6WQvRS#G?eyEi-{c*@m%@J55;3uaRKL;taqZ3+~
zAmR5H61S-zwqdA?i>a@a@@V8DTo84+?7gvTxX@@(aJWNu8BH&*t0z$iCFs;NpsDNd
zOkl#wT_jhwqZfKb#SEo-{)`>BK4&g0E411%b#JPdR`o;fYJrgIBeGW?2xb}6)F@>P
z5~6cS%JrAZ9(0a_l|mCR^Iun%Xeze80u9|`{3@dXexLiA`NjAv6d$!uK~|2r8Dq8d
zo+d^WKOrExm4BW5(<fzM{Efv%q$quYevC2d1M3-{nUx{tbSUI>s1NI@Ca4aHR4%O(
z`axwh8CFFHf-7FUi>Tb^dBt_*6i|0mJ(*|Lgi8h|_Q-(SPpDq~bto@ZFsO1^Icyvn
Phn*vZ!$AdusXwH@j&shh

delta 1182
zcmZvbT}TvB6vvs_duDb<*Vc#JuR>Qse27-Fe2~(upfrj!(ddI(h`<lDtu!PsrJyY-
zv?limAq+_w5~*06hdy*)Bn!((2z>B^ih78`hsr)4y0fA)Y7YnQ-2b`fp5M9u!B2Vj
zKIb(*6q2iiT)O^)<p?)|u4s{%jX{#L=xMd!UnAsd+bTVgxro3+q`8Rg@5}k@HbKb6
zQw_|6y2B<#3ndo@w#!?h-GUE?21Psh%2}s-MeYHnVz3TeSR9iWPL;773_cbZ4Tjki
ztjJ!dT+k(^)8z(s-)E*6jnPy)>v1gEb7Ph+$rx%A8Rg$$w=<Th#Ul);b(GDhrhv1*
zn1_55teyiKqcGrjeYY0AkT`JbX0i=m`@x4bUznR({;+omW*Q20;3bCwLn)TcrGwcQ
zlOWDYqkee5v|kT~6&Wa$4HfBT0Rs;C)Q?BYL8a+3=$A|}-Y$MS1a=KZUHFwR@I$_s
zhSwTlKk5pUV)HH=qxHvNhuw0_=oH7^D2!4op;$2$;>vm1{5H@rwNg^B_yJ47$ud#Z
z9@V<3su9*MPiwmfiL~_+R5SBD&b|;hS1;sZaHo=q!Gks@#jZk&<<4c^F<uylLN*Bp
z&xx++ZaIC?A)e?)$Zrp;K;s?o#0s=@%JCA@S0ss=yP(r@RUBt%k39i5J!fu=uO_>b
zytJwpGFDsKE;%ZCwZ2L}AG)2?Vd$_rGR~A%AbQX_!sXggm|lUrAj??u3RH9tbE7wh
zxaId&fd|tHB_B16gMXcQr}5C5UcspFH-xN~{2$wt$S^p;T-f^7rV>fgT}uZBrPi0p
zuxUnwh|?jF(;@dChSMi%PM*cs5n%%cb(W!ppE<FuRL-PWg*;#d<R;jR`8Bc~$5#n1
z)E8F#m-ZU20&M**1Tb($RA?+Lmsor}|KJ8aeQc8TfXRo8Gc6JUd+KGcHdY&m=>0Me
UI}e42$|HeCA`b`Y{YgKCe^4Wv2mk;8

diff --git a/assets/schemas.json b/assets/schemas.json
index 75c9d90424cd2fdec35d886a29b58c5a765523c9..9b3dd7bea879443e68d2580a066f0d576ec5a935 100644
GIT binary patch
delta 1207
zcmZWoQAm?f6z2Z-+&kUW{kbjMOteW#Dr^R2MBy?F)Tq^i3yMI4AP6#h2$X1+X$Dzw
zvl9l>sPz)4gmRHm41{Eq_*PNqgdj-5eDfvfZcF6;KKwubf6lq*`_6a18|(JPZ~LO-
zMC>I&T-!zu;BW!FMe`mtF;-@jh-jh=N5?6{;SQ+7l6GKt@))nj=p?NWW4XmLbOo4!
z;U!=q^szzOYe<cY1O<t>&~XzQdSi`5J%)@m()HH=AX0&p6C>!y>NqKo&QbbCok`<o
zQmG#V51PLy$FQF}@egC=DNrVszBp4nxV%40AAojjqa&)0PF$D*pPWw6TOO^51m*K(
zI&ZfI7k<<BVr%e49?WKGK^pW|;X|9@!#h98E)iOHi<y0HY?~$wR}%Cx2J#IX{>?G6
z<%ky+b?g+uwZo)PW>-TbSL>^2y|0CYTMOy~r8Nj%057hd28TS~3@@!yDBZVX?hG?=
z<vMraY8NY#ldZ7m)7obCBh`Kem?a@e4;;5ygCqSgt_RbTcnvpB6{+o*kHL}Illo$k
zKZR#{<Fsle%d9{a4#Ak71Er`PuNu@P>t4YlY5~VnCf|=?AGKkpheYJuYZ%<hC1s?|
zwLkG0%*sru=Mim{%D*0B;!HR5Vp|hovSR|~xrV8!E|rb?w&Jx6&_awjnDXKPb&A1!
zWzn6~CeF^~VQrjbr@6@B2e@l$y_NJWkxFsnbCx{*6{5O-RppUV;upyP7lHNNnd`Rj
zT`AhV1QT0?*{H>)q_V@OA8^s?Uoq6YLtH!K!cd%KZOS8+7G1inwV6@zuENk!YL@|%
zS%6cOq@TJlc~HH=rNkx1ifp|-9wvJ{e5y>oJH!X|xiquLZ*{yP$0AC4ZajB_JEREn
T`aPC(N;6FMDIqR(@(KPAr(<$5

delta 1462
zcmZ`(T}V@580I_Q`+akpx|7?~ZHYOtD22_S31PSlBY&XTg$sg6qi!nvg9sy9X_|p%
zeAycYTI9M3OhWnSLNO2$De<nN$O%DERC?!4(6@=m<eZChIPktN&+|Ud^PYIOceKYF
zn<C;MHdgXn43`i;2D`O<97@n})bCLpXRq-ZoS32<pLRht?&$!AU)rGtV{hmIF_~2;
z!>zzHjI00?;rF%DRzWJ9BqT`GiT0aN+c#QA)T7DKI=a!a14t?$ooFFHmd8n+biAUk
zorWzWgzE@y)PE`_5kGg}8e{vCB$!zF<Vf=3a$ug`2gC6#1XKtPT%G~1oL!{1-G<F1
zB%iI)C7W4s`8Vw-G%G&OhWQM`A`SV=aLA&0@y-uYB*GgmF?Yy?ZL@^ouSI$p138)n
z|7B`cIpKkC#@v#NtREphX)T9nmLZO!|F#MiU53SUAyOI!&w~g5o&vi(+XUlgTPr_v
zF>8+Lc&?L!9B2WX&k$kLda0}*W+n}i^g@HhtT-_UQ^v*A@*d5FGX*LD`a`g9MnQcs
z$sfZLW5AT~dsbPV^o_x!aSteSY}l?*r>uSf52y(_Y}9!OBVKC3>uwU23ol{BoNF@E
z+lhPR)!0tv$^f@$D`j}nO>~^=VIFL&Croxt!xA^-kY=D%N$xktZyu&TjM|wxk74Q%
zBRT47c2kQuvyhEdabitzlfidzS2x5`RyIdV#f^^{vf(qtj898l=Fwu}7l{BDfsK;Q
zKg9A^<w(y8Oq&Y1HG}mDmAnt%;iB0|iLs`9(Rtd5;W)|ImQyP2ZW&)%nntMhE5q<H
zYLfw-nGi}&kU{Fi#9{S{6ceYIEU@(Tx|!^C^O?P@<HD8JtGFvj0~o91C*<);j>dYV
lhxAVsx5`V^yeQK|;gopN5#f>jCLKu+Fww6BUF+i0{6F2;ylDUc

diff --git a/src/util/entities/Channel.ts b/src/util/entities/Channel.ts
index 57960ecda..9c7ddb571 100644
--- a/src/util/entities/Channel.ts
+++ b/src/util/entities/Channel.ts
@@ -197,7 +197,7 @@ export class Channel extends BaseClass {
             skipEventEmit?: boolean;
             skipNameChecks?: boolean;
         },
-    ) {
+    ): Promise<Channel> {
         if (!opts?.skipPermissionCheck) {
             // Always check if user has permission first
             const permissions = await getPermission(user_id, channel.guild_id);
@@ -281,7 +281,8 @@ export class Channel extends BaseClass {
             // total_message_sent: 0,
         };
 
-        const ret = Channel.create(channel);
+        // TODO: figure out why the generic is required here
+        const ret = Channel.create<Channel>(channel);
 
         await Promise.all([
             ret.save(),
diff --git a/src/util/util/extensions/Array.test.ts b/src/util/util/extensions/Array.test.ts
deleted file mode 100644
index 6984dfdbe..000000000
--- a/src/util/util/extensions/Array.test.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-import moduleAlias from "module-alias";
-moduleAlias();
-import "./Array";
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-
-describe("Array extensions", () => {
-    //
-});
diff --git a/src/util/util/extensions/Array.ts b/src/util/util/extensions/Array.ts
index f17e8650d..f9cb2fc57 100644
--- a/src/util/util/extensions/Array.ts
+++ b/src/util/util/extensions/Array.ts
@@ -16,14 +16,6 @@
 	along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-declare global {
-    interface Array<T> {
-        /**
-         * @deprecated never use, idk why but I can't get rid of this without errors
-         */
-        remove(h: T): never;
-    }
-}
 /* https://stackoverflow.com/a/50636286 */
 export function arrayPartition<T>(array: T[], filter: (elem: T) => boolean): [T[], T[]] {
     const pass: T[] = [],
@@ -38,5 +30,3 @@ export function arrayRemove<T>(array: T[], item: T): void {
         array.splice(index, 1);
     }
 }
-
-// register extensions