From 039bf2e0f786b06594900fdd62bf06d3490f0d8a Mon Sep 17 00:00:00 2001 From: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com> Date: Thu, 1 Oct 2026 16:01:26 +0400 Subject: [PATCH] core, badge service: say how a verified transaction and a stored payment differ --- apps/simplex-badge-service/src/BadgeService/StoreReceipts.hs | 3 ++- src/Simplex/Chat/PaymentService/Types.hs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/simplex-badge-service/src/BadgeService/StoreReceipts.hs b/apps/simplex-badge-service/src/BadgeService/StoreReceipts.hs index 5f9a30ddcf..23deff5188 100644 --- a/apps/simplex-badge-service/src/BadgeService/StoreReceipts.hs +++ b/apps/simplex-badge-service/src/BadgeService/StoreReceipts.hs @@ -25,7 +25,8 @@ import Simplex.Messaging.Util (catchOwn') import System.Timeout (timeout) -- | What a store vouches for about one completed transaction. --- PaymentFunding's PFApple and PFGoogle hold much the same; the two are reconciled when PaymentFunding is built out. +-- TODO [badges] reconcile with PaymentFunding's PFApple and PFGoogle, which record a payment the +-- service stored rather than what a store attested, when PaymentFunding is built out. data VerifiedStoreTransaction = VerifiedStoreTransaction { transactionRef :: Text, -- from what was verified: Apple's transactionId, googlePurchaseRef of the token asked about productId :: Text, diff --git a/src/Simplex/Chat/PaymentService/Types.hs b/src/Simplex/Chat/PaymentService/Types.hs index 646da675e2..c34e064c1e 100644 --- a/src/Simplex/Chat/PaymentService/Types.hs +++ b/src/Simplex/Chat/PaymentService/Types.hs @@ -139,7 +139,8 @@ data StoredPayment = StoredPayment deriving (Show) -- to review --- PFApple and PFGoogle hold much what the service's VerifiedStoreTransaction does; the two are reconciled when this is built out. +-- TODO [badges] reconcile PFApple and PFGoogle with the badge service's VerifiedStoreTransaction, +-- which is what a store attested rather than a payment recorded here, when this is built out. data PaymentFunding = PFInvoice { invoiceId :: InvoiceId,