core: prevent making all users inactive when duplicate user is created (#1862)

* core: prevent making all users inactive when duplicate user is created

* skip async group test

src/Simplex/Chat.hs

@@ -273,13 +273,16 @@ toView event = do
 processChatCommand :: forall m. ChatMonad m => ChatCommand -> m ChatResponse
 processChatCommand = \case
   ShowActiveUser -> withUser' $ pure . CRActiveUser
-  CreateActiveUser p sameServers -> do
+  CreateActiveUser p@Profile {displayName} sameServers -> do
     u <- asks currentUser
     (smp, smpServers) <- chooseServers
     auId <-
       withStore' getUsers >>= \case
         [] -> pure 1
-        _ -> withAgent (`createUser` smp)
+        users -> do
+          when (any (\User {localDisplayName = n} -> n == displayName) users) $
+            throwChatError $ CEUserExists displayName
+          withAgent (`createUser` smp)
     user <- withStore $ \db -> createUserRecord db (AgentUserId auId) p True
     unless (null smpServers) $
       withStore $ \db -> overwriteSMPServers db user smpServers

src/Simplex/Chat/Controller.hs

@@ -645,6 +645,7 @@ data ChatErrorType
   = CENoActiveUser
   | CENoConnectionUser {agentConnId :: AgentConnId}
   | CEActiveUserExists -- TODO delete
+  | CEUserExists {contactName :: ContactName}
   | CEDifferentActiveUser {commandUserId :: UserId, activeUserId :: UserId}
   | CECantDeleteActiveUser {userId :: UserId}
   | CECantDeleteLastUser {userId :: UserId}

src/Simplex/Chat/View.hs

@@ -1185,6 +1185,7 @@ viewChatError logLevel = \case
     CENoActiveUser -> ["error: active user is required"]
     CENoConnectionUser agentConnId -> ["error: message user not found, conn id: " <> sShow agentConnId | logLevel <= CLLError]
     CEActiveUserExists -> ["error: active user already exists"]
+    CEUserExists name -> ["user with the name " <> ttyContact name <> " already exists"]
     CEDifferentActiveUser commandUserId activeUserId -> ["error: different active user, command user id: " <> sShow commandUserId <> ", active user id: " <> sShow activeUserId]
     CECantDeleteActiveUser _ -> ["cannot delete active user"]
     CECantDeleteLastUser _ -> ["cannot delete last user"]