dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-07-06 15:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ios: clamp removeChatItem unread decrement to match Android (avoid negative badge drift)

Browse Source 
removeChatItem decremented the unread counter unconditionally for an RcvNew item. iOS, unlike
Android's self-clamping decreaseCounterInPrimaryContext, could drive the badge negative if the item
entered the list via upsertChatItem's addChat path (no increment) and was then deleted unread. Only
decrement when the chat's unreadCount > 0.
This commit is contained in:
Narasimha-sc
2026-06-18 15:38:16 +00:00
parent 9863bcb506
commit 342e270a1f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/ios/Shared/Model/ChatModel.swift
+6 -5
View File
@@ -795,14 +795,15 @@ final class ChatModel: ObservableObject {
// update chat list
// memberPending: a support item may be the main-list preview, clear it on delete/moderate (like addChatItem)
if cInfo.groupChatScope() == nil || cInfo.groupInfo?.membership.memberPending ?? false {
if cItem.isRcvNew {
let chat = getChat(cInfo.id)
// clamp: only decrement when there is something to decrement (matches the Android primary-context
// decrement), so deleting an item that never incremented the badge can't drive it negative
if cItem.isRcvNew, let chat, chat.chatStats.unreadCount > 0 {
unreadCollector.changeUnreadCounter(cInfo.id, by: -1, unreadMentions: cItem.meta.userMention ? -1 : 0)
}
// update previews
if let chat = getChat(cInfo.id) {
if let pItem = chat.chatItems.last, pItem.id == cItem.id {
chat.chatItems = [ChatItem.deletedItemDummy()]
}
if let chat, let pItem = chat.chatItems.last, pItem.id == cItem.id {
chat.chatItems = [ChatItem.deletedItemDummy()]
}
}
// remove from current scope