core: don't show no connections diff on event (fix tests) (#6403)

* different approach

* fix tests

src/Simplex/Chat/Options/SQLite.hs

@@ -76,8 +76,8 @@ toDBOpts ChatDbOpts {dbFilePrefix, dbKey, trackQueries, vacuumOnMigration} dbSuf
     { dbFilePath = dbFilePrefix <> dbSuffix,
       dbKey,
       keepKey,
-      track = trackQueries,
-      vacuum = vacuumOnMigration
+      vacuum = vacuumOnMigration,
+      track = trackQueries
     }
 
 chatSuffix :: String

src/Simplex/Chat/View.hs

@@ -1422,21 +1422,30 @@ viewUserPrivacy User {userId} User {userId = userId', localDisplayName = n', sho
   ]
 
 viewConnDiffSync :: DatabaseDiff AgentUserId -> DatabaseDiff AgentConnId -> [StyledString]
-viewConnDiffSync userDiff connDiff =
-  viewConnDiffSummary userDiff connDiff
-    <> ["removed extra users in agent" | not (null $ extraIds userDiff)]
-    <> ["removed extra connections in agent" | not (null $ extraIds connDiff)]
+viewConnDiffSync userDiff connDiff
+  | noDiff userDiff && noDiff connDiff = []
+  | otherwise =
+      viewConnDiffSummary' userDiff connDiff
+        <> ["removed extra users in agent" | not (null $ extraIds userDiff)]
+        <> ["removed extra connections in agent" | not (null $ extraIds connDiff)]
+  where
+    noDiff DatabaseDiff {missingIds, extraIds} = null missingIds && null extraIds
 
 viewConnDiffSummary :: DatabaseDiff AgentUserId -> DatabaseDiff AgentConnId -> [StyledString]
 viewConnDiffSummary userDiff connDiff
   | noDiff userDiff && noDiff connDiff =
       ["no difference between agent and chat connections"]
   | otherwise =
-      ["connections difference summary:"]
-        <> showDatabaseDiff "users" userDiff
-        <> showDatabaseDiff "connections" connDiff
+      viewConnDiffSummary' userDiff connDiff
   where
     noDiff DatabaseDiff {missingIds, extraIds} = null missingIds && null extraIds
+
+viewConnDiffSummary' :: DatabaseDiff AgentUserId -> DatabaseDiff AgentConnId -> [StyledString]
+viewConnDiffSummary' userDiff connDiff =
+  ["connections difference summary:"]
+    <> showDatabaseDiff "users" userDiff
+    <> showDatabaseDiff "connections" connDiff
+  where
     showDatabaseDiff name DatabaseDiff {missingIds, extraIds} =
       ["number of missing " <> name <> " in agent: " <> sShow (length missingIds) | not (null missingIds)]
         <> ["number of extra " <> name <> " in agent: " <> sShow (length extraIds) | not (null extraIds)]