From 36841391e5225e1b2b63c241cadd59eb044b344c Mon Sep 17 00:00:00 2001
From: shum <github.shum@liber.li>
Date: Thu, 22 Oct 2026 05:27:21 +0000
Subject: [PATCH] store: wait on the turn queue in the reveal race

---
 .../src/StoreService/Names/Turns.hs                   |  6 +++++-
 tests/Bots/StoreService/NamesRevealTests.hs           | 11 ++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/apps/simplex-store-service/src/StoreService/Names/Turns.hs b/apps/simplex-store-service/src/StoreService/Names/Turns.hs
index 5f77ed5d4f..b9a5560b6e 100644
--- a/apps/simplex-store-service/src/StoreService/Names/Turns.hs
+++ b/apps/simplex-store-service/src/StoreService/Names/Turns.hs
@@ -1,7 +1,7 @@
 {-# LANGUAGE NamedFieldPuns #-}
 
 -- | A thread that takes a turn it already holds waits forever. Label turns are taken before a code turn.
-module StoreService.Names.Turns (Turns, newTurns, withLabelTurn, withLabelTurns, withCodeTurn, turnsCount) where
+module StoreService.Names.Turns (Turns, newTurns, withLabelTurn, withLabelTurns, withCodeTurn, turnsCount, labelTurnCount) where
 
 import Control.Concurrent.STM
 import Control.Exception (bracket, bracket_)
@@ -32,6 +32,10 @@ withLabelTurns turns a@(LabelHash ha) b@(LabelHash hb) action
 turnsCount :: Turns -> IO Int
 turnsCount Turns {labelTurns, codeTurns} = atomically $ (+) <$> (Map.size <$> readTVar labelTurns) <*> (Map.size <$> readTVar codeTurns)
 
+-- | The requests holding or waiting for the label hash's turn.
+labelTurnCount :: Turns -> LabelHash -> STM Int
+labelTurnCount Turns {labelTurns} (LabelHash h) = maybe 0 snd . Map.lookup h <$> readTVar labelTurns
+
 -- | Keyed by the code's SHA-256 hash.
 withCodeTurn :: Turns -> ByteString -> IO a -> IO a
 withCodeTurn Turns {codeTurns} = withTurn codeTurns
diff --git a/tests/Bots/StoreService/NamesRevealTests.hs b/tests/Bots/StoreService/NamesRevealTests.hs
index aa827fdbf2..eab16a3391 100644
--- a/tests/Bots/StoreService/NamesRevealTests.hs
+++ b/tests/Bots/StoreService/NamesRevealTests.hs
@@ -51,7 +51,7 @@ import StoreService.Names.Phases (RegistrationId (..), publish)
 import StoreService.Names.Registration (Registration (..), makeCommitment, registerIntentDigest, sponsorDomain)
 import StoreService.Names.Signatures (OrderFields (..))
 import StoreService.Names.Store (NamePhase (..), NameRegistration (..), NameReveal (..), VersionWrite (..), getRegistration, retargetRegistration)
-import StoreService.Names.Turns (withLabelTurns)
+import StoreService.Names.Turns (labelTurnCount, withLabelTurns)
 import StoreService.Web.Http (holdMicros, maxBodyBytes, nameBodyBytes, readLimit)
 import StoreService.Web.Names (Route (..), namesApp)
 import StoreService.Web.Names.Registration (registrationHandler, revealHandler)
@@ -253,6 +253,11 @@ moveName ctx@Ctx {cStore, cOrders = OrdersEnv {oeTurns, oePhases}} inTurns rid n
           Written v -> Right v <$ atomically (publish oePhases rid v)
           other -> pure $ Left $ tshow other
 
+-- | Waits until this many requests hold or wait for the label's turn.
+queuedOn :: Ctx -> LabelHash -> Int -> IO ()
+queuedOn Ctx {cOrders = OrdersEnv {oeTurns}} lh n =
+  timeout prompt (atomically $ labelTurnCount oeTurns lh >>= check . (== n)) >>= maybe (fail $ show n <> " requests did not queue on the turn") pure
+
 fieldsOf :: Registration -> OrderFields
 fieldsOf r@Registration {rLabel, rDuration} =
   OrderFields {ofLabelHash = labelHash rLabel, ofLength = T.length rLabel, ofDuration = rDuration, ofCommitment = makeCommitment r, ofSealed = "sealed-" <> rLabel}
@@ -494,7 +499,7 @@ testRacesName = bounded "races /name" $ withReveals $ \Fx {fCtx = ctx, fGate} ->
   rid <- committed ctx (orderOf alice)
   inFlight <- pausedAtChainRead fGate (ownerReveal ctx rid alice)
   move <- async $ moveName ctx (pure ()) rid (fieldsOf moved)
-  timeout 300000 (wait move) >>= (`shouldSatisfy` isNothing)
+  queuedOn ctx (labelHash "alicebakery") 2
   releaseRead fGate
   wait inFlight `shouldReturn` accepted
   wait move `shouldReturn` Left "bad_request"
@@ -510,7 +515,7 @@ testRacesName = bounded "races /name" $ withReveals $ \Fx {fCtx = ctx, fGate} ->
   move' <- async $ moveName ctx (putMVar entered () >> takeMVar release) refusedRid (fieldsOf moved {rLabel = "dynamit"})
   takeMVar entered
   late <- async $ reveal ctx refusedRid body
-  timeout 300000 (wait late) >>= (`shouldSatisfy` isNothing)
+  queuedOn ctx (labelHash "dynamis") 2
   putMVar release ()
   Right v <- wait move'
   (status, answer) <- wait late