From 5008b4e625f99daa22aa0f3370054f6e07a1e59c Mon Sep 17 00:00:00 2001
From: Evgeny Poberezkin <evgeny@poberezkin.com>
Date: Sat, 27 Jun 2026 16:49:03 +0100
Subject: [PATCH] remove trivial tests

---
 simplex-chat.cabal        |  1 -
 tests/ResolveNameTests.hs | 64 ---------------------------------------
 tests/Test.hs             |  2 --
 3 files changed, 67 deletions(-)
 delete mode 100644 tests/ResolveNameTests.hs

diff --git a/simplex-chat.cabal b/simplex-chat.cabal
index 0a5b9b1f61..1b1bb4a5b9 100644
--- a/simplex-chat.cabal
+++ b/simplex-chat.cabal
@@ -592,7 +592,6 @@ test-suite simplex-chat-test
       ProtocolTests
       RandomServers
       RemoteTests
-      ResolveNameTests
       ValidNames
       ViewTests
       API.Docs.Commands
diff --git a/tests/ResolveNameTests.hs b/tests/ResolveNameTests.hs
deleted file mode 100644
index a578f1d122..0000000000
--- a/tests/ResolveNameTests.hs
+++ /dev/null
@@ -1,64 +0,0 @@
-{-# LANGUAGE OverloadedStrings #-}
-
-module ResolveNameTests (resolveNameTests) where
-
-import Data.Text (Text)
-import Simplex.Chat.Controller (ChatError (..), ChatErrorType (..))
-import Simplex.Chat.Library.Commands (firstNameLink)
-import Simplex.Messaging.Agent.Protocol (SimplexNameDomain (..), SimplexNameInfo (..), SimplexNameType (..), SimplexTLD (..))
-import Test.Hspec
-
--- Name resolution/verification is owned by the agent (resolveSimplexName), and link comparison
--- uses the agent's sameConnShortLink / sameShortLinkContact. The only pure helper remaining in the
--- chat layer to cover here is firstNameLink (per-type link selection).
-resolveNameTests :: Spec
-resolveNameTests =
-  -- firstNameLink is the pure link-picker used by dispatchResolvedRecord:
-  -- it selects nrSimplexContact for NTContact, nrSimplexChannel for NTPublicGroup.
-  -- An empty link for the queried type collapses to CESimplexNameNotFound so the
-  -- UX is identical to a local-store miss.
-  describe "firstNameLink" $ do
-    it "NTContact path picks simplexContact" $
-      case firstNameLink NTContact [channelLink] [contactLink] aliceNi of
-        Right lnk -> lnk `shouldBe` contactLink
-        Left e -> expectationFailure $ "expected Right, got " <> show e
-    it "NTPublicGroup path picks simplexChannel" $
-      case firstNameLink NTPublicGroup [channelLink] [contactLink] groupNi of
-        Right lnk -> lnk `shouldBe` channelLink
-        Left e -> expectationFailure $ "expected Right, got " <> show e
-    -- Each per-type field is a list of links (primary first); the first non-empty
-    -- entry is used. firstNameLink filters out empty strings, so a list of only
-    -- empty links collapses to NotFound — same UX as a local-store miss.
-    it "picks the first non-empty link, skipping empty entries" $
-      case firstNameLink NTContact [] ["", contactLink] aliceNi of
-        Right lnk -> lnk `shouldBe` contactLink
-        Left e -> expectationFailure $ "expected Right, got " <> show e
-    it "empty link list returns NotFound" $
-      case firstNameLink NTContact [] [] aliceNi of
-        Left (ChatError (CESimplexNameNotFound ni)) -> ni `shouldBe` aliceNi
-        other -> expectationFailure $ "expected CESimplexNameNotFound, got " <> show other
-    -- Each name advertises a per-type link; cross-type fallback would silently
-    -- connect to the wrong target, so a populated off-type slot must not satisfy
-    -- the queried type.
-    it "cross-type contact link with NTPublicGroup returns NotFound" $
-      case firstNameLink NTPublicGroup [] [contactLink] groupNi of
-        Left (ChatError (CESimplexNameNotFound ni)) -> ni `shouldBe` groupNi
-        other -> expectationFailure $ "expected CESimplexNameNotFound, got " <> show other
-    it "cross-type channel link with NTContact returns NotFound" $
-      case firstNameLink NTContact [channelLink] [] aliceNi of
-        Left (ChatError (CESimplexNameNotFound ni)) -> ni `shouldBe` aliceNi
-        other -> expectationFailure $ "expected CESimplexNameNotFound, got " <> show other
-
-aliceNi :: SimplexNameInfo
-aliceNi = SimplexNameInfo NTContact (SimplexNameDomain TLDSimplex "alice" [])
-
-groupNi :: SimplexNameInfo
-groupNi = SimplexNameInfo NTPublicGroup (SimplexNameDomain TLDSimplex "team" [])
-
--- Synthetic links to exercise firstNameLink's selection logic. The strings are
--- deliberately not real AConnShortLink encodings — the link parser is exercised
--- separately by the A_LINK error path inside dispatchResolvedRecord and by
--- AConnShortLink's own round-trip tests in simplexmq.
-channelLink, contactLink :: Text
-channelLink = "simplex:/channel-team"
-contactLink = "simplex:/contact-alice"
diff --git a/tests/Test.hs b/tests/Test.hs
index 4690983d8c..874428bc1f 100644
--- a/tests/Test.hs
+++ b/tests/Test.hs
@@ -20,7 +20,6 @@ import ProtocolTests
 import OperatorTests
 import RandomServers
 import RemoteTests
-import ResolveNameTests
 import Test.Hspec hiding (it)
 import UnliftIO.Temporary (withTempDirectory)
 import ValidNames
@@ -72,7 +71,6 @@ main = do
       describe "Message batching" batchingTests
       describe "Operators" operatorTests
       describe "Random servers" randomServersTests
-      describe "Resolve SimpleX name" resolveNameTests
 #if defined(dbPostgres)
       createdDropDb . around testBracket
 #else