From 725b6512988418bc5c9599508e52d41b65559aa0 Mon Sep 17 00:00:00 2001 From: Narasimha-sc <166327228+Narasimha-sc@users.noreply.github.com> Date: Thu, 18 Jun 2026 15:33:29 +0000 Subject: [PATCH] docs: plan 2e - scope media preview to pending invitee --- ...026-06-13-fix-wrong-chat-preview-addchatitem.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/plans/2026-06-13-fix-wrong-chat-preview-addchatitem.md b/plans/2026-06-13-fix-wrong-chat-preview-addchatitem.md index 1c74f046b2..4f0c85783c 100644 --- a/plans/2026-06-13-fix-wrong-chat-preview-addchatitem.md +++ b/plans/2026-06-13-fix-wrong-chat-preview-addchatitem.md @@ -1,7 +1,7 @@ # Fix: chat list preview — wrong-chat clobber + pending invitee's member-support messages **PR:** #7072 · **Branch:** `nd/fix-message-preview-and-unread-on-wrong-chat` -**Commits:** `8b93c226d` wrong-chat revert · `862d93c64` sent preview · `bd7c6c3e8`/`55bdaa216` received preview (android-desktop/ios) · `5b37cf881` prefer-content (no event re-covers the preview) · `2b20c9efb`/`8440f17d5` edit/delete preview sync · `1d2a7a3b5` media preview +**Commits:** `8b93c226d` wrong-chat revert · `862d93c64` sent preview · `bd7c6c3e8`/`55bdaa216` received preview (android-desktop/ios) · `5b37cf881` prefer-content (no event re-covers the preview) · `2b20c9efb`/`8440f17d5` edit/delete preview sync · `1d2a7a3b5`/`8bb47e505` media preview **Files:** `ChatModel.kt`/`ChatModel.swift` (`addChatItem`) Part 1 (below) is the original wrong-chat fix. Part 2 (Follow-up, at the end) makes the @@ -195,16 +195,16 @@ never touched. Fix: on an edit in a `GroupChatScopeContext`, also call `chatModel.chatsContext.upsertChatItem` (`ComposeView.kt`). iOS is unaffected (single `chats` list; its `upsertChatItem` already updates the preview via the guard). -## 2e. Media support messages in the preview — `1d2a7a3b5` (android, desktop, ios) +## 2e. Media support messages in the preview — `1d2a7a3b5` · `8bb47e505` (android, desktop, ios) A caption-less photo / video / voice / file support message rendered its **thumbnail** (never gated) but its **text line** showed the status ("reviewed by admins"), because `ChatPreviewView` showed `chatPreviewInfoText()` whenever the last item had no non-empty *text* (`hasMsgContent`) — -which also catches caption-less media. Fix: show the status only for true no-content **events** -(`content.msgContent == null`); any message — including caption-less media — falls through to render -its content ("image" / "video message" / etc.). Captioned media already worked (it has text). Minor: -a direct chat in a pre-connection state with a media last item now shows the media type instead of -the connection status (consistent with the thumbnail that already renders there) — rare. +which also catches caption-less media. Fix: **for a pending invitee only**, show the status text just +for true no-content events (`content.msgContent == null`), so a message — including caption-less media +— renders its content ("image" / "video message" / etc.). Scoped to `memberPending` (`8bb47e505`): +`ChatPreviewView` is shared rendering, so every other chat (direct connection states, other group +states) keeps the original `hasMsgContent` behaviour. Captioned media already worked (it has text). ## 2c. Reload persistence — investigated, **NOT implemented (performance)**