dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-07-13 20:21:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Section: paint item divider on top of clickable's hover indication

Browse Source 
Previously sectionItemDivider() was inside the modifier val before
clickable, so the hover background drew over it inconsistently — on
hover the row's content area got a tinted overlay while the 2dp
divider area stayed at canvas color, creating visible contrast that
read as a "dark line below hovered row".

Moving the modifier to the end of the chain (after clickable+padding)
makes drawBehind paint after the hover indication, so the divider
color is consistently #F2F2F2-ish regardless of hover state.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
another-simple-pixel
2026-05-16 07:43:17 -07:00
parent aeb48d522e
commit 8050676bb7
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/views/helpers/Section.kt
+6 -8
View File
@@ -182,9 +182,9 @@ fun SectionItemView(
val modifier = Modifier val modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.sizeIn(minHeight = minHeight) .sizeIn(minHeight = minHeight)
.sectionItemDivider()
Row( Row(
if (click == null || disabled) modifier.padding(padding) else modifier.clickable(onClick = click).padding(padding), (if (click == null || disabled) modifier.padding(padding) else modifier.clickable(onClick = click).padding(padding))
.sectionItemDivider(),
verticalAlignment = Alignment.CenterVertically verticalAlignment = Alignment.CenterVertically
) { ) {
content() content()
@@ -222,13 +222,12 @@ fun SectionItemViewLongClickable(
val modifier = Modifier val modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.sizeIn(minHeight = minHeight) .sizeIn(minHeight = minHeight)
.sectionItemDivider()
Row( Row(
if (disabled) { (if (disabled) {
modifier.padding(padding) modifier.padding(padding)
} else { } else {
modifier.combinedClickable(onClick = click, onLongClick = longClick).onRightClick(longClick).padding(padding) modifier.combinedClickable(onClick = click, onLongClick = longClick).onRightClick(longClick).padding(padding)
}, }).sectionItemDivider(),
verticalAlignment = Alignment.CenterVertically verticalAlignment = Alignment.CenterVertically
) { ) {
content() content()
@@ -247,11 +246,10 @@ fun SectionItemViewSpaceBetween(
val modifier = Modifier val modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.sizeIn(minHeight = minHeight) .sizeIn(minHeight = minHeight)
.sectionItemDivider()
Row( Row(
if (click == null || disabled) modifier.padding(padding).padding(vertical = DEFAULT_MIN_SECTION_ITEM_PADDING_VERTICAL) else modifier (if (click == null || disabled) modifier.padding(padding).padding(vertical = DEFAULT_MIN_SECTION_ITEM_PADDING_VERTICAL) else modifier
.combinedClickable(onClick = click, onLongClick = onLongClick).padding(padding) .combinedClickable(onClick = click, onLongClick = onLongClick).padding(padding)
.onRightClick { onLongClick?.invoke() }, .onRightClick { onLongClick?.invoke() }).sectionItemDivider(),
horizontalArrangement = Arrangement.SpaceBetween, horizontalArrangement = Arrangement.SpaceBetween,
verticalAlignment = Alignment.CenterVertically verticalAlignment = Alignment.CenterVertically
) { ) {