UserPicker: use canvas color on desktop and split SecondSection around inactive-users grid

Desktop background was MaterialTheme.colors.surface (white) so the SectionView cards introduced earlier were invisible. Switch to canvasColorForCurrentTheme() to match Android. Drop the explicit Divider above the inactive-users grid: split SecondSection into two SectionView cards with the avatar grid between them so the section dividers come from the cards themselves.
2026-05-26 09:44:55 +00:00 · 2026-05-16 13:42:48 -07:00
parent f0383b1873
commit 9bcdcbbbcb
1 changed files with 70 additions and 65 deletions
@@ -142,7 +142,7 @@ fun UserPicker(

  val oneHandUI = remember { appPrefs.oneHandUI.state }
  val iconColor = MaterialTheme.colors.secondaryVariant
-  val background = if (appPlatform.isAndroid) MaterialTheme.colors.background.mixWith(MaterialTheme.colors.onBackground, alpha = 1 - userPickerAlpha()) else MaterialTheme.colors.surface
+  val background = if (appPlatform.isAndroid) MaterialTheme.colors.background.mixWith(MaterialTheme.colors.onBackground, alpha = 1 - userPickerAlpha()) else canvasColorForCurrentTheme()
  PlatformUserPicker(
    modifier = Modifier
      .height(IntrinsicSize.Min)
@@ -216,8 +216,66 @@ fun UserPicker(
      }
    }

+    @Composable
+    fun ProfilesOptionRow() {
+      if (chatModel.desktopNoUserNoRemote) {
+        UserPickerOptionRow(
+          painterResource(MR.images.ic_manage_accounts),
+          generalGetString(MR.strings.create_chat_profile),
+          {
+            doWithAuth(generalGetString(MR.strings.auth_open_chat_profiles), generalGetString(MR.strings.auth_log_in_using_credential)) {
+              ModalManager.center.showModalCloseable { close ->
+                LaunchedEffect(Unit) {
+                  userPickerState.value = AnimatedViewState.HIDING
+                }
+                CreateProfile(chat.simplex.common.platform.chatModel, close)
+              }
+            }
+          }
+        )
+      } else {
+        UserPickerOptionRow(
+          painterResource(MR.images.ic_manage_accounts),
+          stringResource(MR.strings.your_chat_profiles),
+          {
+            ModalManager.start.showCustomModal(keyboardCoversBar = false) { close ->
+              val search = rememberSaveable { mutableStateOf("") }
+              val profileHidden = rememberSaveable { mutableStateOf(false) }
+              val authorized = remember { stateGetOrPut("authorized") { false } }
+              ModalView(
+                { close() },
+                showSearch = true,
+                searchAlwaysVisible = true,
+                onSearchValueChanged = {
+                  search.value = it
+                },
+                content = {
+                  UserProfilesView(chatModel, search, profileHidden) { block ->
+                      if (authorized.value) {
+                        block()
+                      } else {
+                        doWithAuth(
+                          generalGetString(MR.strings.auth_open_chat_profiles),
+                          generalGetString(MR.strings.auth_log_in_using_credential)
+                        ) {
+                          authorized.value = true
+                          block()
+                        }
+                      }
+                    }
+                })
+            }
+          },
+          disabled = stopped
+        )
+      }
+    }
+
    @Composable
    fun SecondSection() {
+      val inactiveUsers = users.filter { !it.user.activeUser }
+      val splitForDesktopGrid = appPlatform.isDesktop && inactiveUsers.isNotEmpty()
+
      SectionView {
        UserPickerOptionRow(
          painterResource(MR.images.ic_qr_code),
@@ -234,74 +292,21 @@ fun UserPicker(
          }),
          disabled = stopped
        )
-        if (appPlatform.isDesktop) {
-          Divider(Modifier.padding(DEFAULT_PADDING))
-
-          val inactiveUsers = users.filter { !it.user.activeUser }
-
-          if (inactiveUsers.isNotEmpty()) {
-            Column(modifier = Modifier.padding(vertical = DEFAULT_MIN_SECTION_ITEM_PADDING_VERTICAL)) {
-              UserPickerUsersSection(
-                users = inactiveUsers,
-                iconColor = iconColor,
-                onUserClicked = onUserClicked,
-                stopped = stopped
-              )
-            }
-          }
+        if (!splitForDesktopGrid) {
+          ProfilesOptionRow()
        }
+      }

-        if (chatModel.desktopNoUserNoRemote) {
-          UserPickerOptionRow(
-            painterResource(MR.images.ic_manage_accounts),
-            generalGetString(MR.strings.create_chat_profile),
-            {
-              doWithAuth(generalGetString(MR.strings.auth_open_chat_profiles), generalGetString(MR.strings.auth_log_in_using_credential)) {
-                ModalManager.center.showModalCloseable { close ->
-                  LaunchedEffect(Unit) {
-                    userPickerState.value = AnimatedViewState.HIDING
-                  }
-                  CreateProfile(chat.simplex.common.platform.chatModel, close)
-                }
-              }
-            }
-          )
-        } else {
-          UserPickerOptionRow(
-            painterResource(MR.images.ic_manage_accounts),
-            stringResource(MR.strings.your_chat_profiles),
-            {
-              ModalManager.start.showCustomModal(keyboardCoversBar = false) { close ->
-                val search = rememberSaveable { mutableStateOf("") }
-                val profileHidden = rememberSaveable { mutableStateOf(false) }
-                val authorized = remember { stateGetOrPut("authorized") { false } }
-                ModalView(
-                  { close() },
-                  showSearch = true,
-                  searchAlwaysVisible = true,
-                  onSearchValueChanged = {
-                    search.value = it
-                  },
-                  content = {
-                    UserProfilesView(chatModel, search, profileHidden) { block ->
-                        if (authorized.value) {
-                          block()
-                        } else {
-                          doWithAuth(
-                            generalGetString(MR.strings.auth_open_chat_profiles),
-                            generalGetString(MR.strings.auth_log_in_using_credential)
-                          ) {
-                            authorized.value = true
-                            block()
-                          }
-                        }
-                      }
-                  })
-              }
-            },
-            disabled = stopped
+      if (splitForDesktopGrid) {
+        Column(modifier = Modifier.padding(vertical = DEFAULT_PADDING_HALF)) {
+          UserPickerUsersSection(
+            users = inactiveUsers,
+            iconColor = iconColor,
+            onUserClicked = onUserClicked,
+            stopped = stopped
          )
        }
+        SectionView { ProfilesOptionRow() }
      }
    }