dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-08-28 12:04:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

desktop: fix Windows in-app updater corrupting install (#7105) (#7136)

Browse Source 
* desktop: fix Windows in-app updater corrupting install by exiting before the MSI runs

The Windows install path ran msiexec while the app was still running and waited for
it. The running JVM holds SimpleX.exe, the JRE and DLLs open, so the per-machine MSI
upgrade cannot replace them, defers to a reboot, and the install ends up broken - the
app fails to launch (#7105). Launch the installer and exit instead, so the files are
unlocked; the user reopens from the Start Menu. Also pass the path via the array form
of exec (fixes spaces in the path) and remove a leftover installer before the next
download, since the exiting app can no longer delete it itself.

* docs: plan justifying the Windows in-app MSI updater fix
This commit is contained in:
Narasimha-sc
2026-07-06 14:56:08 +01:00
committed by GitHub
parent 3b752ff749
commit e79b6ead11
2 changed files with 94 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/multiplatform/common/src/desktopMain/kotlin/chat/simplex/common/views/helpers/AppUpdater.kt
+11 -13
View File
@@ -29,6 +29,7 @@ import java.net.Proxy
import java.nio.file.Files
import java.nio.file.StandardCopyOption
import kotlin.math.min
import kotlin.system.exitProcess
data class SemVer(
val major: Int,
@@ -315,6 +316,10 @@ private suspend fun downloadAsset(asset: GitHubAsset) {
call.execute().use { response ->
response.body?.use { body ->
body.byteStream().use { stream ->
// On Windows the install path exits the app before it can delete the downloaded file, so a
// previous update's installer can be left in the temp dir; remove it here at the next
// download instead of letting it accumulate. Other platforms delete the file after install.
if (desktopPlatform.isWindows()) File(tmpDir, asset.name).delete()
createTmpFileAndDelete { file ->
// It's important to close output stream (with use{}), otherwise, Windows cannot rename the file
file.outputStream().use { output ->
@@ -433,19 +438,12 @@ private suspend fun installAppUpdate(file: File) = withContext(Dispatchers.IO) {
}
}
desktopPlatform.isWindows() -> {
val process = Runtime.getRuntime().exec("msiexec /i ${file.absolutePath}"/* /qb */).onExit().join()
val startedInstallation = process.exitValue() == 0
if (!startedInstallation) {
Log.e(TAG, "Error starting installation: ${process.inputReader().use { it.readLines().joinToString("\n") }}${process.errorStream.use { String(it.readAllBytes()) }}")
// Failed to start installation. show directory with the file for manual installation
desktopOpenDir(file.parentFile)
} else {
AlertManager.shared.showAlertMsg(
title = generalGetString(MR.strings.app_check_for_updates_installed_successfully_title),
text = generalGetString(MR.strings.app_check_for_updates_installed_successfully_desc)
)
file.delete()
}
// Launch the installer, then exit so our files are no longer locked. While the app runs it
// holds SimpleX.exe/JRE/DLLs open, which forces the MSI to defer replacement to a reboot and
// corrupts the upgrade (the app then fails to launch). Array form passes the path as a single
// argument so a space in the temp path does not break the command.
Runtime.getRuntime().exec(arrayOf("msiexec", "/i", file.absolutePath))
exitProcess(0)
}
desktopPlatform.isMac() -> {
// Default mount point if no other DMGs were mounted before