mirror of
https://github.com/simplex-chat/simplex-chat.git
synced 2026-11-04 08:37:30 +00:00
* WIP: Haskell impl of resizeImageToStrSize * WIP: add FFI export wrapper * WIP: switch ios resizeImageToStrSizeSync to backend * WIP: fix resizeImageToStrSizeSync * WIP: add JNI wrappers * Add non-base64 resize and cWriteImage * WIP: add chat_write_image * fix resizeToStr * fixes * fix syntax, raise jpeg quality back * add chatWriteImage * Fix cfArgs in tests * Use jpeg-turbo encoder * add nix pins * bump jpeg-turbo * add CI deps * add encoding funs to android lib * bump jpeg-turbo for 20.04 fix * jpeg-turbo fix for 8.10 * android fixes * Bump jpeg-turbo * set static flag for jpeg-turbo * Fix nix for aarch64/android * Fix android C api * Fix resize in android * Bump hs-libjpeg-turbo * target correct override * override android lib from android pkgs * add macos build tweaks * bump hs-jpeg-turbo for 8.10 fixes * more build fixes * make ios compile * Always use pkgconfig for libjpeg-turbo * WIP: debug libjpeg in ubuntu pkg-config CI * Add pkg-config to dockerfiles * Add libturbojpeg to dockerfiles * Use -dev version of libturbojpeg in dockerfiles * Install pkg-config in windows CI * Disable flag for custom libturbojpeg linking options Workarounds relocation error on x86_64-linux with gcc: /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/13/../../../x86_64-linux-gnu/libturbojpeg.a(turbojpeg.c.o): relocation R_X86_64_TPOFF32 against `errStr' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: failed to set dynamic section sizes: bad value * WIP: debug libjpeg in windows pkg-config CI * WIP: debug libjpeg package in windows CI * core: image resize module and buffer FFI * ci: link libjpeg-turbo statically on all platforms * ui: resize images in the core * core: rename image resize functions to chat_resize_image and chat_resize_image_uri * ci: restore whitespace in build.yml * ci: build libjpeg-turbo 3.1.4.1 from a submodule * core: hs-jpeg-turbo from github.com/simplex-chat * nodejs: resize images * python: resize images * core: hs-jpeg-turbo from gitlab.com, the GitHub import lacks LFS objects * core: generate /img previews * ci: link libjpeg-turbo on Windows without pkg-config * ci: build libjpeg-turbo on Windows with the GHC toolchain * docs: plan for image resizing in the core * docs: update image resizing plan * ios: prevent crash when wallpaper image cannot be resized * android, desktop: raise an error when an image cannot be resized * docs: update spec references for image resizing * docker: build the CLI image from a clone without submodules * docs: apply review fixes to image resizing plan * docker: build the CLI from a git worktree with the submodule present * docs: apply second review to image resizing plan * docs: point image resizing plan at the rewritten commit * core: choose image format by transparency in chat_resize_image * nodejs: resize images to the app sizes * python: resize images to the app sizes * nodejs, python: describe the core modules as used for image resizing * docs: add license notices of the image libraries * ci: describe the avatar method without attributing it to the apps * ci, ios, nix: remove the libjpeg-turbo build outside cabal * python: name resize_image in the core module text * nodejs, python: describe resizing to the app image sizes * core: refuse images larger than the supported size * core: resize to JPEG images with a side above 65500 pixels * docs: record image resizing decisions for the bundled libjpeg-turbo * core, docs: build libjpeg-turbo and stb from the fork submodules * docs: record the fork pins in the image resizing plan * core: resize images to at most 4320 pixels per side, refuse above 16384 * docs: record the image side limits in the image resizing plan * core: pin the rebased hs-jpeg-turbo fork * core: pin the hs-jpeg-turbo fork without package.yaml * docs: plan scaled JPEG decoding and EXIF orientation of images * docs: copy the JuicyPixels-stbir licence of the pinned fork * core: pin the hs-jpeg-turbo fork with scaled JPEG decoding * core: decode JPEG at the display size, up to 65500 pixels per side * core: rotate JPEG images by their EXIF orientation * docs: refer the image plan to the JPEG decoding code * docs: record the approved image processing decisions * core: limit JPEG decoding memory to 1024 MB outside iOS and Android * docs: name JPEG decoding in the libjpeg-turbo notice * docs: plan image resizing from files and the decisions of 26 Oct * core: scale images in one Catmull-Rom pass with sharpening * docs: plan image sizes at a fixed quality * core: resize images at a fixed quality to fill the size limit * core: resize images from a file path or a file descriptor * ios, android, desktop: resize picked images from their files * core: encode resized images with mozjpeg * tests: check descriptor closing by the file it refers to * core: raise JPEG quality only for a full-size image below 97% of the limit * ci: name the mozjpeg submodule in the Windows cleanup comments * docs: refer the image plan to the current code * docs: refer the image plan to the code merged with master * core: export every image resizing function from each library * core: close the file descriptor when its handle cannot be created * docs: count the C sources of mozjpeg with the arithmetic decoder * core: use the reviewed hs-jpeg-turbo and JuicyPixels-stbir forks * ci: build the armv7a Android core library on request * core: round image heights half up in the size search * ios: describe the file image resizing functions in SimpleX.h * ci: pick, preview and send images in the Claude app tests * core: decode PNG images with libspng and refuse other formats * core: encode PNG with libspng, keeping the smaller filter choice * ci: pick, preview and send images in the scripted app smoke tests * flake: build the PNG decoder package in nix builds * ios: remove the copy of a picked image after sending it * core: refuse image files larger than the decode memory limit * core: scale a JPEG image to its largest size once per resize * core: bisect JPEG quality without a step function * core: reduce the memory used to sharpen and to decode PNG images * android, desktop: pass the image format to the core as an integer * android, desktop: fuse the preview conditions of picked media * android, desktop, ci: check that the core resized the smoke test images * python: remove the docstrings of the explicit image resizing functions * docs: add the second review fixes to the image plan * ci: tap the iOS attachment button by its accessibility label * core: keep the colour profiles of resized images * docs: add the colour profiles to the image plan * ci: wait up to 30 s for the new group screens in the iOS smoke test * ci: pick the Android smoke test images from their own photo folders * ci: tap the iOS photo picker by position, as its tree is not shown * ci: pick the test card and the logo by their iOS picker positions * core: update JuicyPixels-stbir with the stb_image_resize licence terms * core: write a fixed Display P3 profile for Display P3 images only * core: do not keep the input image in memory for its colour profile * core: read the JPEG segments once for the orientation and the profile * core: read an image file into one buffer of its size * docs: add the third review fixes to the image plan * core: resize images with Display P3 or no profile, not profile bytes * ci: check the pixel sizes of the images sent in the iOS smoke test * core: update hs-jpeg-turbo with PNG chunk limits and encoder fixes * docs: list Compact ICC Profiles, libspng and miniz in the dependencies * android, desktop: reword the picked media preview comment * docs: refer the image plan to the code merged with master * ci: render the iOS snapshots before the images case * ci: dismiss the snapshot tests' camera alert before the iOS images case * core: update hs-jpeg-turbo with tests and the JuicyPixels-spng synopsis * core: pin hs-jpeg-turbo and JuicyPixels-stbir in simplex-chat repositories * update ios core library * core, ui: accept only JPEG and PNG image data * core: update JuicyPixels-stbir * docs: plan for the iOS copy of picked images --------- Co-authored-by: IC Rainbow <aenor.realm@gmail.com> Co-authored-by: Evgeny Poberezkin <evgeny@poberezkin.com> Co-authored-by: Alexandre Esteves <alexfmpe@proton.me>
289 lines
8.2 KiB
Bash
Executable File
289 lines
8.2 KiB
Bash
Executable File
#!/usr/bin/env sh
|
|
set -eu
|
|
|
|
SIMPLEX_KEY='3C:52:C4:FD:3C:AD:1C:07:C9:B0:0A:70:80:E3:58:FA:B9:FE:FC:B8:AF:5A:EC:14:77:65:F1:6D:0F:21:AD:85'
|
|
|
|
REPO_NAME="simplex-chat"
|
|
REPO="https://github.com/simplex-chat/${REPO_NAME}"
|
|
|
|
IMAGE_NAME='sx-local-android'
|
|
CONTAINER_NAME='sx-builder-android'
|
|
DOCKER_PATH_PROJECT='/project'
|
|
DOCKER_PATH_VERIFY='/verify'
|
|
|
|
export DOCKER_BUILDKIT=1
|
|
|
|
SIMPLEX_REPO='simplex-chat/simplex-chat'
|
|
CMDS="curl git docker"
|
|
|
|
INIT_DIR="$PWD"
|
|
TEMPDIR="$(mktemp -d)"
|
|
PID_MAX_ORIGINAL="$(sysctl -n kernel.pid_max)"
|
|
|
|
ARCHES="${ARCHES:-aarch64 armv7a}"
|
|
|
|
COLOR_CYAN="\033[36m"
|
|
COLOR_RESET="\033[0m"
|
|
|
|
SUFFIX_BUILT='built'
|
|
SUFFIX_DOWNLOADED='downloaded'
|
|
SUFFIX_BUILT_WITH_SIGNATURE='built-with-downloaded-signature'
|
|
|
|
cleanup() {
|
|
rm -rf -- "${TEMPDIR}"
|
|
docker rm --force "${CONTAINER_NAME}" 2>/dev/null || :
|
|
docker image rm "${IMAGE_NAME}" 2>/dev/null || :
|
|
|
|
if [ "$(sysctl -n kernel.pid_max)" != "$PID_MAX_ORIGINAL" ]; then
|
|
printf 'Adjusting kernel.pid_max back to original value...\n'
|
|
if $SUDO sysctl kernel.pid_max="$PID_MAX_ORIGINAL"; then
|
|
printf 'Successfully adjusted kernel.pid_max\n'
|
|
else
|
|
printf 'Failed to adjust kernel.pid_max. Please set the value manually with: %s sysctl kernel.pid_max=%s\n' "$SUDO" "$PID_MAX_ORIGINAL"
|
|
fi
|
|
fi
|
|
}
|
|
trap 'cleanup' EXIT INT
|
|
|
|
check() {
|
|
commands="$1"
|
|
|
|
set +u
|
|
|
|
for i in $commands; do
|
|
if ! command -v "$i" > /dev/null 2>&1; then
|
|
commands_failed="$i $commands_failed"
|
|
fi
|
|
done
|
|
|
|
if [ -n "$commands_failed" ]; then
|
|
commands_failed=${commands_failed% *}
|
|
printf "%s is not found in your \$PATH. Please install them and re-run the script.\n" "$commands_failed"
|
|
exit 1
|
|
fi
|
|
|
|
if [ "$PID_MAX_ORIGINAL" -gt 65535 ]; then
|
|
SUDO=$(command -v sudo || command -v doas) || { echo "No sudo or doas"; exit 1; }
|
|
|
|
printf 'Adjusting kernel.pid_max value to 65535...\n'
|
|
|
|
if $SUDO sysctl kernel.pid_max=65535; then
|
|
printf 'Successfully adjusted kernel.pid_max\n'
|
|
else
|
|
printf 'Failed to adjust kernel.pid_max, aborting.\n'
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
set -u
|
|
}
|
|
|
|
download_apk() {
|
|
tag="$1"
|
|
filename="$2"
|
|
file_out="$3"
|
|
|
|
curl -L "${REPO}/releases/download/${tag}/${filename}" -o "$file_out"
|
|
}
|
|
|
|
setup_git() {
|
|
workdir="$1"
|
|
name="$2"
|
|
|
|
git -C "$workdir" clone "${REPO}.git" "$name"
|
|
}
|
|
|
|
checkout_git() {
|
|
git_dir="$1"
|
|
tag="$2"
|
|
|
|
git -C "$git_dir" reset --hard
|
|
git -C "$git_dir" clean -dfx
|
|
git -C "$git_dir" checkout "$tag"
|
|
git -C "$git_dir" submodule update --init --recursive
|
|
}
|
|
|
|
check_apk() {
|
|
apk_name="$1"
|
|
expected="$2"
|
|
|
|
actual=$(docker exec "${CONTAINER_NAME}" apksigner verify --print-certs "${DOCKER_PATH_VERIFY}/${apk_name}" | grep 'SHA-256' | awk '{print $NF}' | fold -w2 | paste -sd: | tr '[:lower:]' '[:upper:]')
|
|
|
|
if [ "$expected" = "$actual" ]; then
|
|
return 0
|
|
else
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
verify_apk() {
|
|
apk_name="$1"
|
|
|
|
# Release APKs are packaged by AGP (gradle :android:assembleFossRelease; AGP version is
|
|
# gradle.plugin.version in apps/multiplatform/gradle.properties), which zero-pads ZIP
|
|
# alignment. Do NOT add --pad-like-apksigner (standalone apksigner >= 35.0.0-rc1 uses
|
|
# the 0xd935 extra-field padding) unless AGP is bumped to a packager that uses it —
|
|
# otherwise apksigcopier aborts with "APK Signing Block offset < central directory offset".
|
|
# https://github.com/obfusk/apksigcopier?tab=readme-ov-file#what-about-signatures-made-by-apksigner-from-build-tools--3500-rc1
|
|
docker exec "${CONTAINER_NAME}" repro-apk zipalign --page-size 16 --replace "${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_BUILT}" \
|
|
"${DOCKER_PATH_VERIFY}/${apk_name}.aligned"
|
|
docker exec "${CONTAINER_NAME}" mv "${DOCKER_PATH_VERIFY}/${apk_name}.aligned" \
|
|
"${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_BUILT}"
|
|
|
|
docker exec "${CONTAINER_NAME}" apksigcopier copy "${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_DOWNLOADED}" \
|
|
"${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_BUILT}" \
|
|
"${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_BUILT_WITH_SIGNATURE}"
|
|
|
|
downloaded_apk_hash=$(docker exec "${CONTAINER_NAME}" sha256sum "${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_DOWNLOADED}" | awk '{print $1}')
|
|
built_apk_hash=$(docker exec "${CONTAINER_NAME}" sha256sum "${DOCKER_PATH_VERIFY}/${apk_name}.${SUFFIX_BUILT_WITH_SIGNATURE}" | awk '{print $1}')
|
|
|
|
if [ "$downloaded_apk_hash" = "$built_apk_hash" ]; then
|
|
return 0
|
|
else
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
print_vercode() {
|
|
build_dir="$1"
|
|
awk -F'=' '/android.version_code=/ {print $2}' "${build_dir}/apps/multiplatform/gradle.properties"
|
|
}
|
|
|
|
setup_container() {
|
|
dir_git="$1"
|
|
dir_apk="$2"
|
|
|
|
docker build \
|
|
--no-cache \
|
|
-f "${dir_git}/Dockerfile.build" \
|
|
-t "${IMAGE_NAME}" \
|
|
--build-arg=USER_UID="$(id -u)" \
|
|
--build-arg=USER_GID="$(id -g)" \
|
|
.
|
|
|
|
# Run container in background
|
|
docker run -t -d \
|
|
--name "${CONTAINER_NAME}" \
|
|
--device /dev/fuse \
|
|
--cap-add SYS_ADMIN \
|
|
--security-opt apparmor:unconfined \
|
|
--security-opt seccomp:unconfined \
|
|
-v "${dir_git}:${DOCKER_PATH_PROJECT}" \
|
|
-v "${dir_apk}:${DOCKER_PATH_VERIFY}" \
|
|
"${IMAGE_NAME}"
|
|
}
|
|
|
|
build_apk() {
|
|
arch="$1"
|
|
vercode="$2"
|
|
|
|
apk_out="simplex-${arch}.apk.${SUFFIX_BUILT}"
|
|
|
|
# Gradle setup
|
|
docker exec -i "${CONTAINER_NAME}" sh << EOF
|
|
cd $DOCKER_PATH_PROJECT/apps/multiplatform
|
|
./gradlew
|
|
EOF
|
|
|
|
docker exec -i "${CONTAINER_NAME}" sh << EOF
|
|
GRADLE_BIN=\$(find \$HOME/.gradle/wrapper/dists -name "gradle" -type f -executable 2>/dev/null | head -1)
|
|
GRADLE_DIR=\$(dirname "\$GRADLE_BIN")
|
|
export PATH="\$GRADLE_DIR:\$PATH"
|
|
|
|
ARCHES="$arch" ./scripts/android/build-android.sh -gs "$vercode" || ARCHES="$arch" ./scripts/android/build-android.sh -gs "$vercode"
|
|
|
|
APK_FILE=\$(find . -maxdepth 1 -type f -name '*.apk')
|
|
|
|
mv "\$APK_FILE" $DOCKER_PATH_VERIFY/$apk_out
|
|
EOF
|
|
}
|
|
|
|
main() {
|
|
tag="$1"
|
|
|
|
build_directory="${TEMPDIR}/${REPO_NAME}"
|
|
final_directory="$INIT_DIR/${tag}-${REPO_NAME}"
|
|
apk_directory="${final_directory}/android"
|
|
|
|
printf 'This script will:
|
|
1) build docker container.
|
|
2) download APK from GitHub and validate signatures.
|
|
3) build core library with nix (12-24 hours).
|
|
4) build APK and compare with downloaded one
|
|
|
|
The script will ask for sudo password to adjust kernel.pid_max (needed for armv7a build)
|
|
and set it back to otiginal value when the build is done.
|
|
|
|
Continue?'
|
|
|
|
read _
|
|
|
|
check "$CMDS"
|
|
|
|
mkdir -p "${apk_directory}"
|
|
|
|
# Setup initial git for Dockerfile.build
|
|
setup_git "$TEMPDIR" "$REPO_NAME"
|
|
checkout_git "$build_directory" "$tag"
|
|
|
|
printf "${COLOR_CYAN}Building Docker container...${COLOR_RESET}\n"
|
|
setup_container "$build_directory" "$apk_directory"
|
|
|
|
# Check phase
|
|
for arch in $ARCHES; do
|
|
filename="simplex-${arch}.apk"
|
|
|
|
download_apk "$tag" "$filename" "${apk_directory}/${filename}.${SUFFIX_DOWNLOADED}"
|
|
|
|
if check_apk "${filename}.${SUFFIX_DOWNLOADED}" "$SIMPLEX_KEY"; then
|
|
printf "${COLOR_CYAN}APK for %s is signed by valid key.${COLOR_RESET}\n" "$arch"
|
|
else
|
|
printf "${COLOR_CYAN}Signature of APK for %s is invalid., aborting the script.${COLOR_RESET}\n" "$arch"
|
|
exit 1
|
|
fi
|
|
done
|
|
|
|
# Build phase
|
|
for arch in $ARCHES; do
|
|
case "$arch" in
|
|
armv7a)
|
|
# Releases made before the master-android branch was merged have armv7a in a separate tag.
|
|
if git -C "$build_directory" rev-parse -q --verify "refs/tags/${tag}-armv7a" > /dev/null; then
|
|
build_tag="${tag}-armv7a"
|
|
else
|
|
build_tag="${tag}"
|
|
fi
|
|
;;
|
|
aarch64)
|
|
build_tag="${tag}"
|
|
;;
|
|
*)
|
|
printf "${COLOR_CYAN}Unknown architecture: %s! Skipping the build...${COLOR_RESET}\n" "$arch"
|
|
continue
|
|
esac
|
|
|
|
# Setup the code
|
|
checkout_git "$build_directory" "$build_tag"
|
|
vercode=$(print_vercode "$build_directory")
|
|
|
|
printf "${COLOR_CYAN}Building APK for for %s...${COLOR_RESET}\n" "$arch"
|
|
build_apk "$arch" "$vercode"
|
|
done
|
|
|
|
# Verification phase
|
|
for arch in $ARCHES; do
|
|
filename="simplex-${arch}.apk"
|
|
|
|
if ! verify_apk "$filename"; then
|
|
printf "${COLOR_CYAN}Failed to verify %s! Aborting.\n${COLOR_RESET}" "$filename"
|
|
exit 1
|
|
fi
|
|
done
|
|
|
|
printf "${COLOR_CYAN}%s is reproducible.${COLOR_RESET}\n" "$tag"
|
|
|
|
cleanup
|
|
}
|
|
|
|
main "$@"
|