mirror of
https://github.com/simplex-chat/simplex-chat.git
synced 2026-08-14 11:30:18 +00:00
Narasimha-sc
937e688c0a
No behaviour change. The review rounds left the flow carrying their own reasoning: 267 of the 759 added lines were comments, and the fixes had accreted structure that was no longer needed. createProfileForInvitation runs on Main via withApi, as the pickers' own handlers always did, instead of withBGApi with three withContext(Dispatchers.Main) blocks inside it. Every call it makes suspends into IO - sendCmd hops there itself - so Main is never blocked, and the whole class of off-main model mutation that two rounds of review found simply cannot arise. That removes the two coroutine imports as well. hasModalOpenNotClosing is gone: while the form is open it is necessarily the last modal on the fullscreen stack, so the entry guard uses isLastModalOpenNotClosing and one function covers both call sites. The rest is comments. Kept the ones that record why something non-obvious is the way it is - the placement, the main-thread choice, the guards - and dropped the narration of what the earlier attempts got wrong, which belongs in the history and the plan. One comment described code that is not there at all; it is the commit message's job to say why the chatId write was removed. 759 -> 667 added lines, 267 -> 189 of them comments.