mirror of
https://github.com/simplex-chat/simplex-chat.git
synced 2026-08-14 13:40:32 +00:00
Narasimha-sc
f2f5ab3892
Six defects, all in the window between creating the profile and moving the invitation onto it. Pane. The form was shown in ModalManager.center, which on desktop sets ChatModel.chatId to null - and the chat view *is* the centre pane. Tapping "Add profile" in a prepared invitation therefore closed that chat, discarding the typed compose draft with it, and only the success path reopened it: cancelling the form, or any failure, left "No selected chat" with the invitation nowhere on screen. From the one-time link picker, which is itself a start-pane modal, the form appeared in a different pane with the picker still live beside it and no scrim, so a profile could be selected while the form was open - and apiChangeConnectionUser recreates the connection, invalidating the pccConnId the form was about to use. The manager is now passed in: end for the compose picker, matching the incognito modal it already opens there, and start for the one-time link picker, matching its own. In-flight guard. The flag was per-picker and released when the profile existed, not when the invitation had moved. Both are wrong: onCreated only launches the reassignment, and on Android the picker's composition is disposed while the form is on top of it, so the flag it comes back with is a fresh false. There was no spinner, no dimming and every row was live during the switch, so a second tap created a second profile or started a competing reassignment. onCreated is now suspending so the flag covers the whole flow, and the flag is a single top-level state both pickers read. The compose picker had no in-progress state at all and now has one, and its new row was also the only one missing the profileChangeProhibited guard. Active user and host. The reassignment resolves the invitation under whatever profile is active when it runs. A notification tap switches the active user from another dispatcher, and a remote host connect/disconnect switches the host, so both are checked before handing over rather than reassigning under the wrong profile. Torn-down form. isLastModalOpen was used only to decide whether to close the form, and the flow continued when it was false - reassigning and switching under a screen the user had already left. It now stops. Connection not moved. The one-time link picker dismissed itself and turned the app-wide incognito default off whether or not apiChangeConnectionUser succeeded. Unlike the prepared-chat reassignment, that call provisions a new queue, so it is what fails offline - leaving a profile just created for the invitation stranded with nothing pointing at it and the picker gone. It now keeps the picker open and only clears incognito once the connection has actually moved. Reopening the chat. chatModel.chatId was set unconditionally after the switch, before the check that the switch actually happened, pointing the chat view at a chat that had just moved to another profile and defeating the guard in updateChats that clears it. Also applies the users refresh on the main thread, where the receiver loop updates the same list, and skips it when the host has changed underneath.
Android App Development
This is a guide to contributing to the develop of the SimpleX android and desktop apps.
Project Overview
This is the Kotlin Multiplatform (KMP) mobile and desktop client for SimpleX Chat, sharing code between Android and Desktop (JVM) platforms using Compose Multiplatform for UI.
Build Commands
# Android debug APK
./gradlew assembleDebug
# Android release APK
./gradlew assembleRelease
# Desktop distribution (current OS)
./gradlew :desktop:packageDistributionForCurrentOS
# Run desktop/JVM tests
./gradlew desktopTest
# Run Android instrumented tests (requires connected device/emulator)
./gradlew connectedAndroidTest
# Build native libraries for all platforms
./gradlew common:cmakeBuild -PcrossCompile
# Clean build
./gradlew clean
Architecture
Module Structure
common/- Shared code (Compose UI, models, business logic)src/commonMain/- Cross-platform codesrc/androidMain/- Android-specific implementationssrc/desktopMain/- Desktop-specific implementations
android/- Android app containerdesktop/- Desktop JVM app container
Key Components (common/src/commonMain/kotlin/chat/simplex/common/)
model/ChatModel.kt- Main state container with reactive properties (MutableState, MutableStateFlow)model/SimpleXAPI.kt- API bindings to Haskell core library via FFIplatform/Core.kt- FFI interface to nativelibapplibraryplatform/- Platform abstraction layer (expect/actual pattern for Android/Desktop specifics)views/- Compose UI screens organized by feature (chat, chatlist, call, usersettings, etc.)ui/theme/- Design system (colors, typography, shapes)
Native Integration
The app calls into a Haskell core library via JNI/FFI:
- CMake builds in
common/src/commonMain/cpp/android/andcpp/desktop/ - Cross-compilation toolchains in
cpp/toolchains/ - Built libraries go to
cpp/desktop/libs/(organized by platform)
Configuration
local.properties (create from local.properties.example)
compression.level=0 # APK compression (0-9)
enable_debuggable=true # Debug mode
application_id.suffix=.debug # Multiple app instances on same device
app.name=SimpleX Debug # App name for debug builds
gradle.properties
Contains versions (Kotlin, Compose, AGP) and app version info. Key settings:
kotlin.jvm.target=11database.backend=sqlite(orpostgres)
Testing
Tests are in:
common/src/commonTest/kotlin/- Cross-platform testscommon/src/desktopTest/kotlin/- Desktop-specific tests (run with./gradlew desktopTest)android/src/androidTest/- Android instrumented tests
Resources & Localization
- String resources:
common/src/commonMain/resources/MR/base/strings.xml+ 21 language variants - Uses Moko Resources (
dev.icerock.moko:resources) for cross-platform resource management - The
adjustFormattinggradle task validates string resources during build
Platform-Specific Notes
Android
- Min SDK 26, Target SDK 35
- NDK 23.1.7779620
- Supports ABI splits:
arm64-v8a,armeabi-v7a - Deep linking requires SHA certificate fingerprint in
assetlinks.json(see README.md)
Desktop
- Distributions: DMG (macOS), MSI/EXE (Windows), DEB (Linux)
- Mac signing/notarization configured via
local.properties - Video playback uses VLCJ
Gotchas
SHA Signature for verification for app links/deep links
In order for the SimpleX app to be automatically adopted for opening links from https://simplex.chat the SHA certificate fingerprint for the App installed on the phone must be in the hosted assetlinks.json file on simplex.chat.
The accepted fingerprints are in the sha256_cert_fingerprints list.
To find your SHA certificate fingerprint perform the following steps.
- Build and install your development version of the app as usual
- From the terminal in Android studio run
adb shell pm get-app-links chat.simplex.app - Copy the signature listed in
signaturesin the result - Add your signature to assetlinks.json in the website repo and make a PR. On approval, wait a few minutes for the changes to propagate to the public website and then you should be able to verify SimpleX.
More information is available here. If there is no response when running the pm get-app-links command, the intents in AndroidManifest.xml are likely misspecified. A verification attempt can be triggered using adb shell pm verify-app-links --re-verify chat.simplex.app.
Note that this is not an issue for the app store build of the app as this is signed with our app store credentials and thus there is a stable signature over users. Developers do not have general access to these credentials for development and testing.
Adding icons
-
Find a Material symbol in Rounded category.
-
Set weight to 400, grade to -25 and size to 48px.
-
Click on the icon, choose Android and download XML file.
-
Update the color to black (#FF000000) and the size to "24.dp", as in other icons.
For example, this is add reaction icon.