From 5cc872873326e8e8b2afc082106c5f5e03307ef7 Mon Sep 17 00:00:00 2001
From: Evgeny Poberezkin <2769109+epoberezkin@users.noreply.github.com>
Date: Fri, 29 Sep 2023 08:25:54 +0100
Subject: [PATCH] check and change page size when opening connection

---
 src/Simplex/Messaging/Agent/Store/SQLite.hs | 34 ++++++++++++---------
 tests/AgentTests/SQLiteTests.hs             |  8 ++---
 2 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/src/Simplex/Messaging/Agent/Store/SQLite.hs b/src/Simplex/Messaging/Agent/Store/SQLite.hs
index 25fbb0683..aefa79847 100644
--- a/src/Simplex/Messaging/Agent/Store/SQLite.hs
+++ b/src/Simplex/Messaging/Agent/Store/SQLite.hs
@@ -386,15 +386,15 @@ confirmOrExit s = do
 connectSQLiteStore :: FilePath -> String -> IO SQLiteStore
 connectSQLiteStore dbFilePath dbKey = do
   dbNew <- not <$> doesFileExist dbFilePath
-  dbConn <- dbBusyLoop (connectDB dbFilePath dbKey)
+  dbConn <- dbBusyLoop (connectDB dbFilePath dbKey $ not dbNew)
   atomically $ do
     dbConnection <- newTMVar dbConn
     dbEncrypted <- newTVar . not $ null dbKey
     dbClosed <- newTVar False
     pure SQLiteStore {dbFilePath, dbEncrypted, dbConnection, dbNew, dbClosed}
 
-connectDB :: FilePath -> String -> IO DB.Connection
-connectDB path key = do
+connectDB :: FilePath -> String -> Bool -> IO DB.Connection
+connectDB path key checkPageSize = do
   db <- DB.open path
   prepare db `onException` DB.close db
   -- _printPragmas db path
@@ -402,16 +402,22 @@ connectDB path key = do
   where
     prepare db = do
       unless (null key) . execSQL_ db $ "PRAGMA key = " <> sqlString key <> ";"
-      execSQL_ db . fromQuery $
-        [sql|
-          PRAGMA page_size = 16384;
-          PRAGMA journal_mode = WAL;
-          PRAGMA busy_timeout = 100;
-          PRAGMA foreign_keys = ON;
-          -- PRAGMA trusted_schema = OFF;
-          PRAGMA secure_delete = ON;
-          PRAGMA auto_vacuum = FULL;
-        |]
+      when checkPageSize $ do
+        pageSize :: Maybe Int <- maybeFirstRow fromOnly $ SQL.query_ (DB.conn db) "PRAGMA page_size;"
+        when (pageSize == Just 16384) $ execSQL_ db
+          "PRAGMA wal_checkpoint(TRUNCATE);\n\
+          \PRAGMA journal_mode = DELETE;\n\
+          \PRAGMA page_size = 16384;\n\
+          \VACUUM;\n\
+          \PRAGMA journal_mode = WAL;"
+      execSQL_ db
+        "PRAGMA page_size = 16384;\n\
+        \PRAGMA journal_mode = WAL;\n\
+        \PRAGMA busy_timeout = 100;\n\
+        \PRAGMA foreign_keys = ON;\n\
+        \-- PRAGMA trusted_schema = OFF;\n\
+        \PRAGMA secure_delete = ON;\n\
+        \PRAGMA auto_vacuum = FULL;"
 
 closeSQLiteStore :: SQLiteStore -> IO ()
 closeSQLiteStore st@SQLiteStore {dbClosed} =
@@ -430,7 +436,7 @@ openSQLiteStore SQLiteStore {dbConnection, dbFilePath, dbClosed} key =
         (atomically $ takeTMVar dbConnection)
         (atomically . tryPutTMVar dbConnection)
         $ \DB.Connection {slow} -> do
-          DB.Connection {conn} <- connectDB dbFilePath key
+          DB.Connection {conn} <- connectDB dbFilePath key False
           atomically $ do
             putTMVar dbConnection DB.Connection {conn, slow}
             writeTVar dbClosed False
diff --git a/tests/AgentTests/SQLiteTests.hs b/tests/AgentTests/SQLiteTests.hs
index a2c8e3929..1055fb5b7 100644
--- a/tests/AgentTests/SQLiteTests.hs
+++ b/tests/AgentTests/SQLiteTests.hs
@@ -526,8 +526,8 @@ testCloseReopenStore = do
   hasMigrations st
   closeSQLiteStore st
   errorGettingMigrations st
-  openSQLiteStore st ""
-  hasMigrations st
+  Right st' <- createSQLiteStore (dbFilePath st) "" Migrations.app MCError
+  hasMigrations st'
 
 testCloseReopenEncryptedStore :: IO ()
 testCloseReopenEncryptedStore = do
@@ -542,8 +542,8 @@ testCloseReopenEncryptedStore = do
   hasMigrations st
   closeSQLiteStore st
   errorGettingMigrations st
-  openSQLiteStore st key
-  hasMigrations st
+  Right st' <- createSQLiteStore (dbFilePath st) key Migrations.app MCError
+  hasMigrations st'
 
 getMigrations :: SQLiteStore -> IO Bool
 getMigrations st = not . null <$> withTransaction st (Migrations.getCurrent . DB.conn)