more review fixes

This commit is contained in:
Alain Brenzikofer committed 2026-09-05 19:51:01 +02:00
1 parent 69cce33675
commit 783f0aa4be
13 files changed
+67 -30

No files matched your search

+7 -4
View File
@@ -200,10 +200,13 @@ then be quoted at list price while the registrar charges the premium. Configure
`SNRC_CONTROLLER_<TLD>` wherever `SNRC_REGISTRAR_<TLD>` is set, and upgrade this
service before the routers that query it.
Upgrade the resolver before the router that queries it. A resolver without this
status reports a name in its auction as plain `expired`, which reads as "free at
the ordinary price" — the price the registrar actually charges is still the
premium one, so the quote is wrong until the resolver is current.
**Upgrade this service before the routers that query it.** Routers from v22 hash
the 2LD of every query, and two things only this version does are needed to
answer them: decoding a bracket label that sits under a subname
(`sub.[<hash>].tld`, which an older resolver hashes as literal text and so
answers about a node nobody asked about), and reporting `auction` at all — an
older resolver calls a name in its auction plain `expired`, which reads as "free
at the ordinary price" while the registrar charges the premium.
### Why a name is reserved
+3 -2
View File
@@ -66,8 +66,8 @@ Unrecognised payloads fall back to `0x`-prefixed raw hex.
import hashlib
import json
import os
import time
import sys
import time
from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
from urllib.parse import unquote, urlparse
from urllib.request import Request, urlopen
@@ -289,7 +289,8 @@ def name_status(name: str):
}
# nameExpires and reservedNames are keyed on uint256(keccak(label)).
# Decoded for a 2LD only, the same rule node_of applies to the node.
# Only the 2LD's label is a registry key, wherever in the name it sits, so it
# is the only one decoded - the same rule node_of applies to the node.
label = labels[-2]
if is_encoded_labelhash(label):
token = int(label[1:-1], 16)