From 08511cc830f0c4414cd8dd5c1a91995be4675760 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Fri, 29 May 2026 12:09:32 +0100 Subject: [PATCH] Add FIXME to remove USE_FROZEN_DICTS --- synapse/events/__init__.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/synapse/events/__init__.py b/synapse/events/__init__.py index 970970c1f8..659ae7b3f6 100644 --- a/synapse/events/__init__.py +++ b/synapse/events/__init__.py @@ -58,13 +58,9 @@ Whether we should use frozen_dict in FrozenEvent. Using frozen_dicts prevents bugs where we accidentally share e.g. signature dicts. However, converting a dict to frozen_dicts is expensive. -NOTE: This is overridden by the configuration by the Synapse worker apps, but -for the sake of tests, it is set here because it cannot be configured on the -homeserver object itself. - -FIXME: Because of how this option works (changing the underlying types), it causes -subtle downstream bugs that makes type comparisons brittle, tracked by -https://github.com/element-hq/synapse/issues/18117 +FIXME: This is no longer used as when we switched to using the Rust +implementation, all events are immutable already (and so don't benefit from +freezing). """