From 12d4f2d089e0c7ba4e1a9820a5bdcfe61d1c9d12 Mon Sep 17 00:00:00 2001 From: Jason Robinson Date: Mon, 20 Jul 2026 15:20:48 +0300 Subject: [PATCH] Fix comment re SQLite and JSON --- synapse/storage/databases/main/profile.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/synapse/storage/databases/main/profile.py b/synapse/storage/databases/main/profile.py index f6ca9369d0..534661bd30 100644 --- a/synapse/storage/databases/main/profile.py +++ b/synapse/storage/databases/main/profile.py @@ -337,8 +337,7 @@ class ProfileWorkerStore(SQLBaseStore): retcol="fields", desc="get_profile_fields", ) - # The SQLite driver doesn't automatically convert JSON to - # Python objects + # The SQLite driver doesn't have a JSON datatype. if isinstance(self.database_engine, Sqlite3Engine) and result: result = json.loads(result) return result or {} @@ -572,8 +571,7 @@ class ProfileWorkerStore(SQLBaseStore): results: dict[str, dict[str, JsonValue | dict[str, JsonValue]]] = {} for full_user_id, displayname, avatar_url, fields in rows: user_fields = fields or {} - # The SQLite driver doesn't automatically convert JSON to - # Python objects + # The SQLite driver doesn't have a JSON datatype. if isinstance(self.database_engine, Sqlite3Engine) and fields: user_fields = json.loads(fields) base_fields = {