From 19537992f1089cca46986092da3b809e09aa4a43 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Tue, 28 Jul 2026 21:42:06 -0500 Subject: [PATCH] `start_doing_background_updates` once and for all databases The code has evolved since I first put this PR up, see https://github.com/element-hq/synapse/pull/19181 --- synapse/app/homeserver.py | 4 ---- synapse/server.py | 3 ++- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/synapse/app/homeserver.py b/synapse/app/homeserver.py index 2b1760416b..0d5560b46d 100644 --- a/synapse/app/homeserver.py +++ b/synapse/app/homeserver.py @@ -449,10 +449,6 @@ async def start( await _base.start(hs, freeze=freeze) - # TODO: Feels like this should be moved somewhere else. - for db in hs.get_datastores().databases: - db.updates.start_doing_background_updates() - def start_reactor( config: HomeServerConfig, diff --git a/synapse/server.py b/synapse/server.py index cf33e04962..9448eb76b4 100644 --- a/synapse/server.py +++ b/synapse/server.py @@ -670,7 +670,8 @@ class HomeServer(metaclass=abc.ABCMeta): self.get_task_scheduler() self.get_common_usage_metrics_manager().setup() start_phone_stats_home(self) - self.get_datastores().main.db_pool.updates.start_doing_background_updates() + for db in self.get_datastores().databases: + db.updates.start_doing_background_updates() def get_reactor(self) -> ISynapseReactor: """