From b849bed8f96b6c5221fc20e23a7af3c5e6f71eed Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 23 Jun 2025 11:55:17 -0500 Subject: [PATCH] Make broken hack more obvious when it happens --- synapse/metrics/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/metrics/__init__.py b/synapse/metrics/__init__.py index c7ad8005e3..9fa72d4fcd 100644 --- a/synapse/metrics/__init__.py +++ b/synapse/metrics/__init__.py @@ -96,7 +96,7 @@ def _set_prometheus_client_use_created_metrics(new_value: bool) -> None: if hasattr(prometheus_client.metrics, "_use_created"): prometheus_client.metrics._use_created = new_value else: - logger.error( + raise Exception( "Can't disable `_created` metrics in prometheus_client (brittle hack broken?)" )