From c16dbe7dbc8c3cf9a79188767db45b9860187583 Mon Sep 17 00:00:00 2001 From: Jason Robinson Date: Fri, 10 Jul 2026 15:13:18 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- synapse/api/constants.py | 2 +- synapse/handlers/profile.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/synapse/api/constants.py b/synapse/api/constants.py index 5304c09951..041a7f284a 100644 --- a/synapse/api/constants.py +++ b/synapse/api/constants.py @@ -426,7 +426,7 @@ class ProfileUpdateAction(str, enum.Enum): we always include the full profile of users who have joined a room the syncing user is a member of, where full profile means all the current profile values the client asked for, regardless of whether they have changed recently. This ensures - that clients have profile re-populated for any users who have recently left + that clients have profiles re-populated for any users who have recently left shared rooms. A scenario example would be as follows: diff --git a/synapse/handlers/profile.py b/synapse/handlers/profile.py index d44ed482db..b17dffcded 100644 --- a/synapse/handlers/profile.py +++ b/synapse/handlers/profile.py @@ -655,7 +655,7 @@ class ProfileHandler: field_name: str, new_value: JsonValue | dict[str, JsonValue], by_admin: bool = False, - propagate: bool = False, + propagate: bool = True, ) -> None: """ Dispatch setting a profile field value. This either happens in the same