From d7e0d353ff4f8ec0e8a9c1b4eda65f6378d50b32 Mon Sep 17 00:00:00 2001 From: Jason Robinson Date: Tue, 7 Jul 2026 19:18:23 +0300 Subject: [PATCH] Add some notes on missing tests for future readers I changed things so deactivation did call these and no tests failed. --- synapse/handlers/profile.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/synapse/handlers/profile.py b/synapse/handlers/profile.py index f937dc1a23..6b7a5dc7fd 100644 --- a/synapse/handlers/profile.py +++ b/synapse/handlers/profile.py @@ -261,6 +261,8 @@ class ProfileHandler: updates into rooms, which could cause rooms to be accidentally joined after the deactivated user has left them. + FIXME: This precondition seems to lack a test. + Args: target_user: the user whose displayname is to be changed. requester: The user attempting to make this change. @@ -385,6 +387,8 @@ class ProfileHandler: updates into rooms, which could cause rooms to be accidentally joined after the deactivated user has left them. + FIXME: This precondition seems to lack a test. + Args: target_user: the user whose avatar URL is to be changed. requester: The user attempting to make this change. @@ -829,6 +833,8 @@ class ProfileHandler: notify modules about the change whilst claiming it is not related to user deactivation. + FIXME: This precondition seems to lack a test. + Args: target_user: the user whose profile is to be changed. requester: The user attempting to make this change. @@ -914,6 +920,8 @@ class ProfileHandler: notify modules about the change whilst claiming it is not related to user deactivation. + FIXME: This precondition seems to lack a test. + Args: target_user: the user whose profile is to be changed. requester: The user attempting to make this change.