From f1ebd97a90d3cc17d27ba7aea035e830491484b2 Mon Sep 17 00:00:00 2001 From: Will Hunt <2072976+Half-Shot@users.noreply.github.com> Date: Mon, 11 May 2026 16:06:14 +0100 Subject: [PATCH] Fix Twitter OpenGraph parsing Lots to do here, but some of the assumptions are wrong. --- synapse/media/preview_html.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/synapse/media/preview_html.py b/synapse/media/preview_html.py index 4f9315f4c9..221decba1c 100644 --- a/synapse/media/preview_html.py +++ b/synapse/media/preview_html.py @@ -242,10 +242,9 @@ def _map_twitter_to_open_graph(key: str) -> str | None: be ignored. """ # Twitter card properties with no analogous Open Graph property. - if key == "twitter:card" or key == "twitter:creator": + # twitter:site is the user's handle - https://web.archive.org/web/20200828150337/https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup + if key == "twitter:card" or key == "twitter:creator" or key == "twitter:site": return None - if key == "twitter:site": - return "og:site_name" # Otherwise, swap twitter to og. return "og" + key[7:]