From f2afc627ef7332e201a9d051a9dd8962ae3d1d2f Mon Sep 17 00:00:00 2001 From: Kegan Dougal <7190048+kegsay@users.noreply.github.com> Date: Thu, 23 Apr 2026 08:12:51 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Eric Eastwood --- changelog.d/19718.misc | 2 +- synapse/storage/databases/main/event_federation.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changelog.d/19718.misc b/changelog.d/19718.misc index b7fa1e9730..5914943f34 100644 --- a/changelog.d/19718.misc +++ b/changelog.d/19718.misc @@ -1 +1 @@ -Add storage functions for future MSC4242 work. +Add storage functions for future [MSC4242](https://github.com/matrix-org/matrix-spec-proposals/pull/4242) work. diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py index bf08824eb4..4d3a77c74a 100644 --- a/synapse/storage/databases/main/event_federation.py +++ b/synapse/storage/databases/main/event_federation.py @@ -1252,6 +1252,7 @@ class EventFederationWorkerStore( # Remove comment when used. async def get_missing_events_state_dag( self, + *, room_id: str, earliest_events: list[str], latest_events: list[str], @@ -1267,8 +1268,8 @@ class EventFederationWorkerStore( ) return await self.get_events_as_list(ids) - # 22/04/2026: Unused currently, but will be used in future MSC4242 PRs. - # Remove comment when used. + # FIXME(2026-04-22): Remove comment when used. Unused currently, but will be used in + # future MSC4242 PRs. def _get_missing_events_state_dag_txn( self, txn: LoggingTransaction,