dandri/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2026-08-06 23:40:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix release script considering any workflow completion as successful. (#19843)

Browse Source 
When building the v1.155.0rc1, the release notification said the
workflow was successful
but it had actually failed.

---------

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
This commit is contained in:
Olivier 'reivilibre
2026-06-15 12:29:49 +01:00
committed by GitHub
parent d7e9a3ff83
commit f2f159d6c1
2 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts-dev/release.py
+21 -11
View File
@@ -611,18 +611,28 @@ def _wait_for_actions(gh_token: str | None) -> None:
if len(resp["workflow_runs"]) == 0:
continue
if all(
workflow["status"] != "in_progress" for workflow in resp["workflow_runs"]
):
success = all(
workflow["status"] == "completed" for workflow in resp["workflow_runs"]
)
if success:
_notify("Workflows successful. You can now continue the release.")
else:
_notify("Workflows failed.")
click.confirm("Continue anyway?", abort=True)
# Notify early if any workflow run has already failed.
failed_workflows = [
workflow
for workflow in resp["workflow_runs"]
if workflow["status"] == "completed" and workflow["conclusion"] != "success"
]
if failed_workflows:
for workflow in failed_workflows:
print(
f"Workflow run failed ({workflow['conclusion']}): {workflow['name']}"
)
print(f" see {workflow['html_url']}")
_notify("A workflow run has failed.")
click.confirm("Continue anyway?", abort=True)
break
# If every run has completed successfully, we are done.
if all(
workflow["status"] == "completed" and workflow["conclusion"] == "success"
for workflow in resp["workflow_runs"]
):
_notify("Workflows successful. You can now continue the release.")
break