mirror of
https://github.com/element-hq/synapse.git
synced 2026-11-14 20:28:28 +00:00
Ankit Jha
0744b28c6a
Fixes #20035 `_MultipartParserProtocol` assigned each `on_header_field` / `on_header_value` / `on_part_data` value instead of accumulating it. python-multipart calls these once per `dataReceived` chunk, so any header name, header value or JSON part split across two chunks kept only its last piece. A long `Location` in a federated media redirect was the visible case: the truncated URL had no host and `get_file` failed with `TypeError`. The protocol now buffers header names, header values and the JSON part in `bytearray`s and acts on them in `on_header_end` / `on_part_end`, with a part counter replacing the `in_json` / `json_done` / `in_*` flags. The file part still streams straight to the output stream, and the existing `max_length` check still bounds everything that gets buffered. The new tests parse a file response and a redirect response split at every byte offset, and byte by byte, and check the result matches the unsplit parse. Before the fix, 100 and 115 split offsets respectively produced a wrong result. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Signed-off-by: Ankit Jha <ankit.jha@tradomate.one> Signed-off-by: Ankit Jha <jhaankit373@gmail.com>