mirror of
https://github.com/element-hq/synapse.git
synced 2026-11-10 05:58:11 +00:00
bf9a68b017
> [!NOTE] > Epic: [Efficient Server Announcements](https://github.com/element-hq/synapse/issues/20240) > Follows: https://github.com/element-hq/synapse/pull/20372 This PR first tests that every user can read the server announcements through the "history" endpoints like - [x] `GET /rooms/{roomId}/messages` - [x] `GET /rooms/{roomId}/context/{eventId}` - [x] `GET /rooms/{roomId}/event/{eventId}` - [x] `GET /rooms/{roomId}/relations/{eventId}` - [x] `GET /rooms/{roomId}/threads` - [x] `GET /rooms/{roomId}/initialSync` This already works for users who have never been in the room, because announcement rooms are world-readable. It doesn't for a sender who was removed from the room's config: Synapse still uses their `leave` membership and shows them the room as it was when they left. This PR then treats a user who left a configured announcement room like a user who has never been in it. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Quentin Gliech <quenting@element.io>