mirror of
https://github.com/element-hq/synapse.git
synced 2026-08-14 15:50:19 +00:00
Erik JohnstonandClaude Fable 5
429baac202
- get_thread_id/main_thread claimed to return an 'OS thread id'; restore the historical caveat that threading.get_ident is not an OS tid and is stable across Synapse's single fork() (which is also why the new per-thread cache stays correct across it). - Explain skip_from_py_object on ContextResourceUsage (pyo3 0.28 makes the Clone-pyclass FromPyObject opt-in/out explicit; we build -D warnings). - Note that __repr__ diverges from the historical Python repr for exponent-form floats, and that main_thread is settable only for tests. - Promote create_deferred's cancellation limitation to a TODO and cross-reference run_python_awaitable's finished-context defence. - Carry the dropped Python docstrings into the .pyi stub (start/stop 'do not call directly', get_resource_usage returns a *copy*, __init__ args, the sentinel usage guidance), and note that tag is typed str while the runtime deliberately also accepts None. - tests: fix the stale rust/src/logcontext.rs path, explain why 'synapse' is in _RUST_LOGGER_ROOTS (the crate is named synapse) and the Python- namespace collision hazard, drop a stale deferred.rs:223 FIXME reference, explain the 50000-iteration pump bound, and rename prepare's parameter to match the base class (pyright). - docs: name the helper (LogContext::capture/scope) instead of 'the provided helper'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFbRtswu7rsHrttJFauUUb