mirror of
https://github.com/element-hq/synapse.git
synced 2026-04-26 02:12:20 +00:00
ac26cfac83
--- Summary: Synapse Twisted → asyncio Migration What's been built (Phases 0-7) — 10 new files, ~3200 lines, 96 tests Every Twisted component has an asyncio-native replacement ready: ┌──────────────────┬───────────────────────────────────────────────┬─────────────────────────────────────────────────────────┬───────────────────────────────────────────────┐ │ Component │ Twisted Original │ asyncio Replacement │ File │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ LoggingContext │ threading.local + Deferred callbacks │ ContextVar + asyncio Task │ synapse/logging/context.py (native functions) │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Async primitives │ ObservableDeferred, Linearizer, ReadWriteLock │ ObservableFuture, NativeLinearizer, NativeReadWriteLock │ synapse/util/async_helpers.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Cache │ DeferredCache │ FutureCache │ synapse/util/caches/future_cache.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Clock │ Clock (Twisted reactor) │ NativeClock (asyncio) │ synapse/util/clock.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Database │ adbapi.ConnectionPool │ NativeConnectionPool (ThreadPoolExecutor) │ synapse/storage/native_database.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ HTTP Client │ treq + Twisted Agent │ aiohttp.ClientSession │ synapse/http/native_client.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ HTTP Server │ JsonResource + Twisted Site │ NativeJsonResource + aiohttp.web │ synapse/http/native_server.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Replication │ LineOnlyReceiver (Twisted Protocol) │ asyncio.StreamReader/Writer │ synapse/replication/tcp/native_protocol.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Event loop │ ISynapseReactor │ ISynapseEventLoop │ synapse/types/__init__.py │ ├──────────────────┼───────────────────────────────────────────────┼─────────────────────────────────────────────────────────┼───────────────────────────────────────────────┤ │ Test helper │ — │ FakeAsyncioLoop │ tests/async_helpers.py │ └──────────────────┴───────────────────────────────────────────────┴─────────────────────────────────────────────────────────┴───────────────────────────────────────────────┘ What's been wired in safely — 224 files changed, 0 regressions - MemoryReactor type hint → Any across 198 test files (cosmetic) - synapse/http/server.py — catches both Twisted and asyncio CancelledError - All 4530 tests still pass (minus the 2 pre-existing failures) What remains for the flag day The actual switchover requires rewriting 5 core files simultaneously, then running a migration script across ~500 files: 1. tests/unittest.py + tests/server.py — switch from twisted.trial.TestCase to unittest.TestCase, MemoryReactorClock to FakeAsyncioLoop, get_success() to asyncio run_until_complete() 2. synapse/logging/context.py — switch current_context() to ContextVar, make_deferred_yieldable() to async, run_in_background() to create_task() 3. synapse/util/async_helpers.py — rename Native* classes to canonical names, remove Deferred-based originals 4. Migration script — update all CancelledError, defer.*, Deferred imports across ~500 files 5. pyproject.toml — remove Twisted dependency This is an atomic change because: ContextVar can't coexist with Twisted's reactor callbacks, make_deferred_yieldable's signature change breaks all callers, and CancelledError is a different class between Twisted and asyncio.
279 lines
11 KiB
Python
279 lines
11 KiB
Python
#
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
#
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# See the GNU Affero General Public License for more details:
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
#
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
#
|
|
# [This file includes modifications made by New Vector Limited]
|
|
#
|
|
#
|
|
from http import HTTPStatus
|
|
|
|
from typing import Any as MemoryReactor # was: MemoryReactor from Twisted
|
|
|
|
import synapse.rest.admin
|
|
from synapse.api.room_versions import KNOWN_ROOM_VERSIONS
|
|
from synapse.rest.client import capabilities, login
|
|
from synapse.server import HomeServer
|
|
from synapse.util.clock import Clock
|
|
|
|
from tests import unittest
|
|
from tests.unittest import override_config
|
|
|
|
|
|
class CapabilitiesTestCase(unittest.HomeserverTestCase):
|
|
servlets = [
|
|
synapse.rest.admin.register_servlets_for_client_rest_resource,
|
|
capabilities.register_servlets,
|
|
login.register_servlets,
|
|
]
|
|
|
|
def make_homeserver(self, reactor: MemoryReactor, clock: Clock) -> HomeServer:
|
|
self.url = b"/capabilities"
|
|
hs = self.setup_test_homeserver()
|
|
self.config = hs.config
|
|
self.auth_handler = hs.get_auth_handler()
|
|
return hs
|
|
|
|
def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
|
|
self.localpart = "user"
|
|
self.password = "pass"
|
|
self.user = self.register_user(self.localpart, self.password)
|
|
|
|
def test_check_auth_required(self) -> None:
|
|
channel = self.make_request("GET", self.url)
|
|
|
|
self.assertEqual(channel.code, 401)
|
|
|
|
def test_get_room_version_capabilities(self) -> None:
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, 200)
|
|
for room_version in capabilities["m.room_versions"]["available"].keys():
|
|
self.assertTrue(room_version in KNOWN_ROOM_VERSIONS, "" + room_version)
|
|
|
|
self.assertEqual(
|
|
self.config.server.default_room_version.identifier,
|
|
capabilities["m.room_versions"]["default"],
|
|
)
|
|
|
|
def test_get_change_password_capabilities_password_login(self) -> None:
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, 200)
|
|
self.assertTrue(capabilities["m.change_password"]["enabled"])
|
|
|
|
@override_config({"password_config": {"localdb_enabled": False}})
|
|
def test_get_change_password_capabilities_localdb_disabled(self) -> None:
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, 200)
|
|
self.assertFalse(capabilities["m.change_password"]["enabled"])
|
|
|
|
@override_config({"password_config": {"enabled": False}})
|
|
def test_get_change_password_capabilities_password_disabled(self) -> None:
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, 200)
|
|
self.assertFalse(capabilities["m.change_password"]["enabled"])
|
|
|
|
def test_get_change_users_attributes_capabilities(self) -> None:
|
|
"""Test that server returns capabilities by default."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertTrue(capabilities["m.change_password"]["enabled"])
|
|
self.assertTrue(capabilities["m.set_displayname"]["enabled"])
|
|
self.assertTrue(capabilities["m.set_avatar_url"]["enabled"])
|
|
self.assertTrue(capabilities["m.3pid_changes"]["enabled"])
|
|
|
|
@override_config({"enable_set_displayname": False})
|
|
def test_get_set_displayname_capabilities_displayname_disabled(self) -> None:
|
|
"""Test if set displayname is disabled that the server responds it."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.set_displayname"]["enabled"])
|
|
self.assertTrue(capabilities["m.profile_fields"]["enabled"])
|
|
self.assertEqual(
|
|
capabilities["m.profile_fields"]["disallowed"], ["displayname"]
|
|
)
|
|
|
|
@override_config({"enable_set_avatar_url": False})
|
|
def test_get_set_avatar_url_capabilities_avatar_url_disabled(self) -> None:
|
|
"""Test if set avatar_url is disabled that the server responds it."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.set_avatar_url"]["enabled"])
|
|
self.assertTrue(capabilities["m.profile_fields"]["enabled"])
|
|
self.assertEqual(capabilities["m.profile_fields"]["disallowed"], ["avatar_url"])
|
|
|
|
@override_config(
|
|
{
|
|
"enable_set_displayname": False,
|
|
"experimental_features": {"msc4133_enabled": True},
|
|
}
|
|
)
|
|
def test_get_set_displayname_capabilities_displayname_disabled_msc4133(
|
|
self,
|
|
) -> None:
|
|
"""Test if set displayname is disabled that the server responds it."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.set_displayname"]["enabled"])
|
|
self.assertTrue(capabilities["m.profile_fields"]["enabled"])
|
|
self.assertEqual(
|
|
capabilities["m.profile_fields"]["disallowed"], ["displayname"]
|
|
)
|
|
self.assertTrue(capabilities["uk.tcpip.msc4133.profile_fields"]["enabled"])
|
|
self.assertEqual(
|
|
capabilities["uk.tcpip.msc4133.profile_fields"]["disallowed"],
|
|
["displayname"],
|
|
)
|
|
|
|
@override_config(
|
|
{
|
|
"enable_set_avatar_url": False,
|
|
"experimental_features": {"msc4133_enabled": True},
|
|
}
|
|
)
|
|
def test_get_set_avatar_url_capabilities_avatar_url_disabled_msc4133(self) -> None:
|
|
"""Test if set avatar_url is disabled that the server responds it."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.set_avatar_url"]["enabled"])
|
|
self.assertTrue(capabilities["m.profile_fields"]["enabled"])
|
|
self.assertEqual(capabilities["m.profile_fields"]["disallowed"], ["avatar_url"])
|
|
self.assertTrue(capabilities["uk.tcpip.msc4133.profile_fields"]["enabled"])
|
|
self.assertEqual(
|
|
capabilities["uk.tcpip.msc4133.profile_fields"]["disallowed"],
|
|
["avatar_url"],
|
|
)
|
|
|
|
@override_config({"enable_3pid_changes": False})
|
|
def test_get_change_3pid_capabilities_3pid_disabled(self) -> None:
|
|
"""Test if change 3pid is disabled that the server responds it."""
|
|
access_token = self.login(self.localpart, self.password)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.3pid_changes"]["enabled"])
|
|
|
|
def test_get_get_token_login_fields_when_disabled(self) -> None:
|
|
"""By default login via an existing session is disabled."""
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(capabilities["m.get_login_token"]["enabled"])
|
|
|
|
@override_config({"login_via_existing_session": {"enabled": True}})
|
|
def test_get_get_token_login_fields_when_enabled(self) -> None:
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertTrue(capabilities["m.get_login_token"]["enabled"])
|
|
|
|
@override_config(
|
|
{
|
|
"experimental_features": {"msc4267_enabled": True},
|
|
"forget_rooms_on_leave": True,
|
|
}
|
|
)
|
|
def test_get_forget_forced_upon_leave_with_auto_forget(self) -> None:
|
|
# Server auto-forgets on /leave, expect enabled client capability
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertTrue(
|
|
capabilities["org.matrix.msc4267.forget_forced_upon_leave"]["enabled"]
|
|
)
|
|
|
|
@override_config(
|
|
{
|
|
"experimental_features": {"msc4267_enabled": True},
|
|
"forget_rooms_on_leave": False,
|
|
}
|
|
)
|
|
def test_get_forget_forced_upon_leave_without_auto_forget(self) -> None:
|
|
# Server doesn't auto-forget on /leave, expect disabled client capability
|
|
access_token = self.get_success(
|
|
self.auth_handler.create_access_token_for_user_id(
|
|
self.user, device_id=None, valid_until_ms=None
|
|
)
|
|
)
|
|
channel = self.make_request("GET", self.url, access_token=access_token)
|
|
capabilities = channel.json_body["capabilities"]
|
|
self.assertEqual(channel.code, HTTPStatus.OK)
|
|
self.assertFalse(
|
|
capabilities["org.matrix.msc4267.forget_forced_upon_leave"]["enabled"]
|
|
)
|