mirror of
https://github.com/element-hq/synapse.git
synced 2026-05-24 19:35:20 +00:00
Erik Johnston
ff55aff5b2
When we port the `Event` class to Rust, the constructor will check for the existence of required fields. To support that, we tidy up the test code where we construct fake events to add all the required fields. There should be no behavioural changes. Review commit-by-commit.
1059 lines
35 KiB
Python
1059 lines
35 KiB
Python
#
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
#
|
|
# Copyright 2015, 2016 OpenMarket Ltd
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# See the GNU Affero General Public License for more details:
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
#
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
#
|
|
# [This file includes modifications made by New Vector Limited]
|
|
#
|
|
#
|
|
|
|
import unittest as stdlib_unittest
|
|
from typing import TYPE_CHECKING, Any, Mapping
|
|
|
|
from parameterized import parameterized
|
|
|
|
from synapse.api.constants import EventContentFields
|
|
from synapse.api.room_versions import RoomVersions
|
|
from synapse.events import EventBase
|
|
from synapse.events.utils import (
|
|
FilteredEvent,
|
|
PowerLevelsContent,
|
|
SerializeEventConfig,
|
|
_split_field,
|
|
clone_event,
|
|
copy_and_fixup_power_levels_contents,
|
|
format_event_raw,
|
|
make_config_for_admin,
|
|
maybe_upsert_event_field,
|
|
prune_event,
|
|
)
|
|
from synapse.types import JsonDict, create_requester
|
|
from synapse.util.frozenutils import freeze
|
|
|
|
from tests.test_utils.event_builders import make_test_event
|
|
from tests.unittest import HomeserverTestCase
|
|
|
|
if TYPE_CHECKING:
|
|
from synapse.server import HomeServer
|
|
|
|
|
|
class TestMaybeUpsertEventField(stdlib_unittest.TestCase):
|
|
def test_update_okay(self) -> None:
|
|
event = make_test_event({"event_id": "$1234"})
|
|
success = maybe_upsert_event_field(
|
|
event, event.unsigned, "replaces_state", "value"
|
|
)
|
|
self.assertTrue(success)
|
|
self.assertEqual(event.unsigned["replaces_state"], "value")
|
|
|
|
def test_update_not_okay(self) -> None:
|
|
event = make_test_event({"event_id": "$1234"})
|
|
LARGE_STRING = "a" * 100_000
|
|
success = maybe_upsert_event_field(
|
|
event, event.unsigned, "replaces_state", LARGE_STRING
|
|
)
|
|
self.assertFalse(success)
|
|
self.assertNotIn("replaces_state", event.unsigned)
|
|
|
|
def test_update_not_okay_leaves_original_value(self) -> None:
|
|
event = make_test_event(
|
|
{"event_id": "$1234", "unsigned": {"replaces_state": "value"}}
|
|
)
|
|
LARGE_STRING = "a" * 100_000
|
|
success = maybe_upsert_event_field(
|
|
event, event.unsigned, "replaces_state", LARGE_STRING
|
|
)
|
|
self.assertFalse(success)
|
|
self.assertEqual(event.unsigned["replaces_state"], "value")
|
|
|
|
|
|
class PruneEventTestCase(stdlib_unittest.TestCase):
|
|
# Fields that `make_test_event` fills in by default and that `prune_event`
|
|
# preserves as spec-required keep fields. Pruning tests only spell out the
|
|
# fields they care about; these are merged into the expected dict so each
|
|
# test stays focused on what it is actually checking.
|
|
_DEFAULT_KEPT_FIELDS: JsonDict = {
|
|
"sender": "@test:test",
|
|
"room_id": "!test:test",
|
|
"depth": 1,
|
|
"origin_server_ts": 1,
|
|
"hashes": {},
|
|
"auth_events": [],
|
|
"prev_events": [],
|
|
}
|
|
|
|
def run_test(self, evdict: JsonDict, matchdict: JsonDict, **kwargs: Any) -> None:
|
|
"""
|
|
Asserts that a new event constructed with `evdict` will look like
|
|
`matchdict` when it is redacted.
|
|
|
|
Args:
|
|
evdict: The dictionary to build the event from.
|
|
matchdict: The expected resulting dictionary.
|
|
kwargs: Additional keyword arguments used to create the event.
|
|
"""
|
|
expected = {**self._DEFAULT_KEPT_FIELDS, **matchdict}
|
|
self.assertEqual(
|
|
prune_event(make_test_event(evdict, **kwargs)).get_dict(), expected
|
|
)
|
|
|
|
def test_minimal(self) -> None:
|
|
self.run_test(
|
|
{"type": "A", "event_id": "$test:domain"},
|
|
{
|
|
"type": "A",
|
|
"event_id": "$test:domain",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
def test_basic_keys(self) -> None:
|
|
"""Ensure that the keys that should be untouched are kept."""
|
|
self.run_test(
|
|
{
|
|
"event_id": "$3:domain",
|
|
"type": "A",
|
|
"room_id": "!1:domain",
|
|
"sender": "@2:domain",
|
|
"state_key": "B",
|
|
"content": {"other_key": "foo"},
|
|
"hashes": {"sha256": "abc"},
|
|
"signatures": {"domain": {"algo:1": "sigs"}},
|
|
"depth": 4,
|
|
"prev_events": [],
|
|
"prev_state": "prev_state",
|
|
"auth_events": [],
|
|
"origin": "domain", # historical top-level field that still exists on old events
|
|
"origin_server_ts": 1234,
|
|
"membership": "join",
|
|
# Also include a key that should be removed.
|
|
"other_key": "foo",
|
|
},
|
|
{
|
|
"event_id": "$3:domain",
|
|
"type": "A",
|
|
"room_id": "!1:domain",
|
|
"sender": "@2:domain",
|
|
"state_key": "B",
|
|
"hashes": {"sha256": "abc"},
|
|
"depth": 4,
|
|
"prev_events": [],
|
|
"prev_state": "prev_state",
|
|
"auth_events": [],
|
|
"origin": "domain", # historical top-level field that still exists on old events
|
|
"origin_server_ts": 1234,
|
|
"membership": "join",
|
|
"content": {},
|
|
"signatures": {"domain": {"algo:1": "sigs"}},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# As of room versions we now redact the membership and prev_states keys.
|
|
self.run_test(
|
|
{
|
|
"type": "A",
|
|
"prev_state": "prev_state",
|
|
"membership": "join",
|
|
},
|
|
{"type": "A", "content": {}, "signatures": {}, "unsigned": {}},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
def test_unsigned(self) -> None:
|
|
"""Ensure that unsigned properties get stripped (except age_ts and replaces_state)."""
|
|
self.run_test(
|
|
{
|
|
"type": "B",
|
|
"event_id": "$test:domain",
|
|
"unsigned": {
|
|
"age_ts": 20,
|
|
"replaces_state": "$test2:domain",
|
|
"other_key": "foo",
|
|
},
|
|
},
|
|
{
|
|
"type": "B",
|
|
"event_id": "$test:domain",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {"age_ts": 20, "replaces_state": "$test2:domain"},
|
|
},
|
|
)
|
|
|
|
def test_content(self) -> None:
|
|
"""The content dictionary should be stripped in most cases."""
|
|
self.run_test(
|
|
{"type": "C", "event_id": "$test:domain", "content": {"things": "here"}},
|
|
{
|
|
"type": "C",
|
|
"event_id": "$test:domain",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# Some events keep a single content key/value.
|
|
EVENT_KEEP_CONTENT_KEYS = [
|
|
("member", "membership", "join"),
|
|
("join_rules", "join_rule", "invite"),
|
|
("history_visibility", "history_visibility", "shared"),
|
|
]
|
|
for event_type, key, value in EVENT_KEEP_CONTENT_KEYS:
|
|
self.run_test(
|
|
{
|
|
"type": "m.room." + event_type,
|
|
"event_id": "$test:domain",
|
|
"content": {key: value, "other_key": "foo"},
|
|
},
|
|
{
|
|
"type": "m.room." + event_type,
|
|
"event_id": "$test:domain",
|
|
"content": {key: value},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
def test_create(self) -> None:
|
|
"""Create events are partially redacted until MSC2176."""
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.create",
|
|
"event_id": "$test:domain",
|
|
"content": {"creator": "@2:domain", "other_key": "foo"},
|
|
},
|
|
{
|
|
"type": "m.room.create",
|
|
"event_id": "$test:domain",
|
|
"content": {"creator": "@2:domain"},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# After MSC2176, create events should preserve field `content`
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.create",
|
|
"content": {"not_a_real_key": True},
|
|
"nonsense_field": "some_random_garbage",
|
|
},
|
|
{
|
|
"type": "m.room.create",
|
|
"content": {"not_a_real_key": True},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
def test_power_levels(self) -> None:
|
|
"""Power level events keep a variety of content keys."""
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.power_levels",
|
|
"event_id": "$test:domain",
|
|
"content": {
|
|
"ban": 1,
|
|
"events": {"m.room.name": 100},
|
|
"events_default": 2,
|
|
"invite": 3,
|
|
"kick": 4,
|
|
"redact": 5,
|
|
"state_default": 6,
|
|
"users": {"@admin:domain": 100},
|
|
"users_default": 7,
|
|
"other_key": 8,
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.power_levels",
|
|
"event_id": "$test:domain",
|
|
"content": {
|
|
"ban": 1,
|
|
"events": {"m.room.name": 100},
|
|
"events_default": 2,
|
|
# Note that invite is not here.
|
|
"kick": 4,
|
|
"redact": 5,
|
|
"state_default": 6,
|
|
"users": {"@admin:domain": 100},
|
|
"users_default": 7,
|
|
},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# After MSC2176, power levels events keep the invite key.
|
|
self.run_test(
|
|
{"type": "m.room.power_levels", "content": {"invite": 75}},
|
|
{
|
|
"type": "m.room.power_levels",
|
|
"content": {"invite": 75},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
def test_alias_event(self) -> None:
|
|
"""Alias events have special behavior up through room version 6."""
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.aliases",
|
|
"event_id": "$test:domain",
|
|
"content": {"aliases": ["test"]},
|
|
},
|
|
{
|
|
"type": "m.room.aliases",
|
|
"event_id": "$test:domain",
|
|
"content": {"aliases": ["test"]},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# After MSC2432, alias events have no special behavior.
|
|
self.run_test(
|
|
{"type": "m.room.aliases", "content": {"aliases": ["test"]}},
|
|
{
|
|
"type": "m.room.aliases",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V6,
|
|
)
|
|
|
|
def test_redacts(self) -> None:
|
|
"""Redaction events have no special behaviour until MSC2174/MSC2176."""
|
|
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.redaction",
|
|
"content": {"redacts": "$test2:domain"},
|
|
"redacts": "$test2:domain",
|
|
},
|
|
{
|
|
"type": "m.room.redaction",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V6,
|
|
)
|
|
|
|
# After MSC2174, redaction events keep the redacts content key.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.redaction",
|
|
"content": {"redacts": "$test2:domain"},
|
|
"redacts": "$test2:domain",
|
|
},
|
|
{
|
|
"type": "m.room.redaction",
|
|
"content": {"redacts": "$test2:domain"},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
def test_join_rules(self) -> None:
|
|
"""Join rules events have changed behavior starting with MSC3083."""
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.join_rules",
|
|
"event_id": "$test:domain",
|
|
"content": {
|
|
"join_rule": "invite",
|
|
"allow": [],
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.join_rules",
|
|
"event_id": "$test:domain",
|
|
"content": {"join_rule": "invite"},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# After MSC3083, the allow key is protected from redaction.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.join_rules",
|
|
"content": {
|
|
"join_rule": "invite",
|
|
"allow": [],
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.join_rules",
|
|
"content": {
|
|
"join_rule": "invite",
|
|
"allow": [],
|
|
},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V8,
|
|
)
|
|
|
|
def test_member(self) -> None:
|
|
"""Member events have changed behavior in MSC3375 and MSC3821."""
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.member",
|
|
"event_id": "$test:domain",
|
|
"content": {
|
|
"membership": "join",
|
|
EventContentFields.AUTHORISING_USER: "@user:domain",
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.member",
|
|
"event_id": "$test:domain",
|
|
"content": {"membership": "join"},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
)
|
|
|
|
# After MSC3375, the join_authorised_via_users_server key is protected
|
|
# from redaction.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "join",
|
|
EventContentFields.AUTHORISING_USER: "@user:domain",
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "join",
|
|
EventContentFields.AUTHORISING_USER: "@user:domain",
|
|
},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V9,
|
|
)
|
|
|
|
# After MSC3821, the signed key under third_party_invite is protected
|
|
# from redaction.
|
|
THIRD_PARTY_INVITE = {
|
|
"display_name": "alice",
|
|
"signed": {
|
|
"mxid": "@alice:example.org",
|
|
"signatures": {
|
|
"magic.forest": {
|
|
"ed25519:3": "fQpGIW1Snz+pwLZu6sTy2aHy/DYWWTspTJRPyNp0PKkymfIsNffysMl6ObMMFdIJhk6g6pwlIqZ54rxo8SLmAg"
|
|
}
|
|
},
|
|
"token": "abc123",
|
|
},
|
|
}
|
|
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "invite",
|
|
"third_party_invite": THIRD_PARTY_INVITE,
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "invite",
|
|
"third_party_invite": {"signed": THIRD_PARTY_INVITE["signed"]},
|
|
},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
# Ensure this doesn't break if an invalid field is sent.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "invite",
|
|
"third_party_invite": {},
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {"membership": "invite", "third_party_invite": {}},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {
|
|
"membership": "invite",
|
|
"third_party_invite": "stripped",
|
|
"other_key": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.member",
|
|
"content": {"membership": "invite"},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V11,
|
|
)
|
|
|
|
def test_relations(self) -> None:
|
|
"""Event relations get redacted until MSC3389."""
|
|
# Normally the m._relates_to field is redacted.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {
|
|
"body": "foo",
|
|
"m.relates_to": {
|
|
"rel_type": "rel_type",
|
|
"event_id": "$parent:domain",
|
|
"other": "stripped",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.V10,
|
|
)
|
|
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {
|
|
"body": "foo",
|
|
"m.relates_to": {
|
|
"rel_type": "rel_type",
|
|
"event_id": "$parent:domain",
|
|
"other": "stripped",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {
|
|
"m.relates_to": {
|
|
"rel_type": "rel_type",
|
|
"event_id": "$parent:domain",
|
|
},
|
|
},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.MSC3389v10,
|
|
)
|
|
|
|
# If the field is not an object, redact it.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {
|
|
"body": "foo",
|
|
"m.relates_to": "stripped",
|
|
},
|
|
},
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.MSC3389v10,
|
|
)
|
|
|
|
# If the m.relates_to property would be empty, redact it.
|
|
self.run_test(
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {"body": "foo", "m.relates_to": {"foo": "stripped"}},
|
|
},
|
|
{
|
|
"type": "m.room.message",
|
|
"content": {},
|
|
"signatures": {},
|
|
"unsigned": {},
|
|
},
|
|
room_version=RoomVersions.MSC3389v10,
|
|
)
|
|
|
|
|
|
class CloneEventTestCase(stdlib_unittest.TestCase):
|
|
def test_unsigned_is_copied(self) -> None:
|
|
original = make_test_event(
|
|
{
|
|
"type": "A",
|
|
"event_id": "$test:domain",
|
|
"unsigned": {"age_ts": 1, "replaces_state": "2"},
|
|
},
|
|
RoomVersions.V1,
|
|
{"txn_id": "txn"},
|
|
)
|
|
original.internal_metadata.stream_ordering = 1234
|
|
self.assertEqual(original.internal_metadata.stream_ordering, 1234)
|
|
original.internal_metadata.instance_name = "worker1"
|
|
self.assertEqual(original.internal_metadata.instance_name, "worker1")
|
|
|
|
cloned = clone_event(original)
|
|
cloned.unsigned["age_ts"] = 3
|
|
|
|
self.assertEqual(
|
|
original.unsigned.for_event(), {"age_ts": 1, "replaces_state": "2"}
|
|
)
|
|
self.assertEqual(
|
|
cloned.unsigned.for_event(), {"age_ts": 3, "replaces_state": "2"}
|
|
)
|
|
self.assertEqual(cloned.internal_metadata.stream_ordering, 1234)
|
|
self.assertEqual(cloned.internal_metadata.instance_name, "worker1")
|
|
self.assertEqual(cloned.internal_metadata.txn_id, "txn")
|
|
|
|
|
|
class SerializeEventTestCase(HomeserverTestCase):
|
|
def prepare(self, reactor: Any, clock: Any, hs: "HomeServer") -> None:
|
|
self._event_serializer = hs.get_event_client_serializer()
|
|
|
|
def serialize(
|
|
self,
|
|
ev: EventBase,
|
|
fields: list[str] | None,
|
|
include_admin_metadata: bool = False,
|
|
redaction_map: Mapping[str, EventBase] | None = None,
|
|
) -> JsonDict:
|
|
return self.get_success(
|
|
self._event_serializer.serialize_event(
|
|
FilteredEvent(event=ev, membership=None),
|
|
1479807801915,
|
|
config=SerializeEventConfig(
|
|
only_event_fields=fields,
|
|
include_admin_metadata=include_admin_metadata,
|
|
),
|
|
redaction_map=redaction_map,
|
|
)
|
|
)
|
|
|
|
def test_event_fields_works_with_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(sender="@alice:localhost", room_id="!foo:bar"),
|
|
["room_id"],
|
|
),
|
|
{"room_id": "!foo:bar"},
|
|
)
|
|
|
|
def test_event_fields_works_with_nested_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={"body": "A message"},
|
|
),
|
|
["content.body"],
|
|
),
|
|
{"content": {"body": "A message"}},
|
|
)
|
|
|
|
def test_event_fields_works_with_dot_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={"key.with.dots": {}},
|
|
),
|
|
[r"content.key\.with\.dots"],
|
|
),
|
|
{"content": {"key.with.dots": {}}},
|
|
)
|
|
|
|
def test_event_fields_works_with_nested_dot_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={
|
|
"not_me": 1,
|
|
"nested.dot.key": {"leaf.key": 42, "not_me_either": 1},
|
|
},
|
|
),
|
|
[r"content.nested\.dot\.key.leaf\.key"],
|
|
),
|
|
{"content": {"nested.dot.key": {"leaf.key": 42}}},
|
|
)
|
|
|
|
def test_event_fields_nops_with_unknown_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
),
|
|
["content.foo", "content.notexists"],
|
|
),
|
|
{"content": {"foo": "bar"}},
|
|
)
|
|
|
|
def test_event_fields_nops_with_non_dict_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={"foo": ["I", "am", "an", "array"]},
|
|
),
|
|
["content.foo.am"],
|
|
),
|
|
{},
|
|
)
|
|
|
|
def test_event_fields_nops_with_array_keys(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
sender="@alice:localhost",
|
|
room_id="!foo:bar",
|
|
content={"foo": ["I", "am", "an", "array"]},
|
|
),
|
|
["content.foo.1"],
|
|
),
|
|
{},
|
|
)
|
|
|
|
def test_event_fields_all_fields_if_empty(self) -> None:
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
type="foo",
|
|
event_id="test",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
),
|
|
[],
|
|
),
|
|
{
|
|
"type": "foo",
|
|
"event_id": "test",
|
|
"room_id": "!foo:bar",
|
|
"content": {"foo": "bar"},
|
|
"unsigned": {},
|
|
"sender": "@test:test",
|
|
"user_id": "@test:test",
|
|
"origin_server_ts": 1,
|
|
},
|
|
)
|
|
|
|
def test_event_fields_fail_if_fields_not_str(self) -> None:
|
|
with self.assertRaises(TypeError):
|
|
SerializeEventConfig(
|
|
only_event_fields=["room_id", 4], # type: ignore[list-item]
|
|
)
|
|
|
|
def test_default_serialize_config_excludes_admin_metadata(self) -> None:
|
|
# We just really don't want this to be set to True accidentally
|
|
self.assertFalse(SerializeEventConfig().include_admin_metadata)
|
|
|
|
def test_event_flagged_for_admins(self) -> None:
|
|
# Default behaviour should be *not* to include it
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
type="foo",
|
|
event_id="test",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
internal_metadata_dict={"soft_failed": True},
|
|
),
|
|
[],
|
|
),
|
|
{
|
|
"type": "foo",
|
|
"event_id": "test",
|
|
"room_id": "!foo:bar",
|
|
"content": {"foo": "bar"},
|
|
"unsigned": {},
|
|
"sender": "@test:test",
|
|
"user_id": "@test:test",
|
|
"origin_server_ts": 1,
|
|
},
|
|
)
|
|
|
|
# When asked though, we should set it
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
type="foo",
|
|
event_id="test",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
internal_metadata_dict={"soft_failed": True},
|
|
),
|
|
[],
|
|
True,
|
|
),
|
|
{
|
|
"type": "foo",
|
|
"event_id": "test",
|
|
"room_id": "!foo:bar",
|
|
"content": {"foo": "bar"},
|
|
"unsigned": {"io.element.synapse.soft_failed": True},
|
|
"sender": "@test:test",
|
|
"user_id": "@test:test",
|
|
"origin_server_ts": 1,
|
|
},
|
|
)
|
|
self.assertEqual(
|
|
self.serialize(
|
|
make_test_event(
|
|
type="foo",
|
|
event_id="test",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
internal_metadata_dict={
|
|
"soft_failed": True,
|
|
"policy_server_spammy": True,
|
|
},
|
|
),
|
|
[],
|
|
True,
|
|
),
|
|
{
|
|
"type": "foo",
|
|
"event_id": "test",
|
|
"room_id": "!foo:bar",
|
|
"content": {"foo": "bar"},
|
|
"unsigned": {
|
|
"io.element.synapse.soft_failed": True,
|
|
"io.element.synapse.policy_server_spammy": True,
|
|
},
|
|
"sender": "@test:test",
|
|
"user_id": "@test:test",
|
|
"origin_server_ts": 1,
|
|
},
|
|
)
|
|
|
|
def test_make_serialize_config_for_admin_retains_other_fields(self) -> None:
|
|
non_default_config = SerializeEventConfig(
|
|
include_admin_metadata=False, # should be True in a moment
|
|
as_client_event=False, # default True
|
|
event_format=format_event_raw, # default format_event_for_client_v1
|
|
requester=create_requester("@example:example.org"), # default None
|
|
only_event_fields=["foo"], # default None
|
|
include_stripped_room_state=True, # default False
|
|
)
|
|
admin_config = make_config_for_admin(non_default_config)
|
|
self.assertEqual(
|
|
admin_config.as_client_event, non_default_config.as_client_event
|
|
)
|
|
self.assertEqual(admin_config.event_format, non_default_config.event_format)
|
|
self.assertEqual(admin_config.requester, non_default_config.requester)
|
|
self.assertEqual(
|
|
admin_config.only_event_fields, non_default_config.only_event_fields
|
|
)
|
|
self.assertEqual(
|
|
admin_config.include_stripped_room_state,
|
|
admin_config.include_stripped_room_state,
|
|
)
|
|
self.assertTrue(admin_config.include_admin_metadata)
|
|
|
|
def test_redacted_because_is_filtered_out(self) -> None:
|
|
"""If an event's unsigned dict has a `redacted_by` field, then the
|
|
`redacted_because` should be filtered out if not specified in
|
|
`only_event_fields`."""
|
|
|
|
redaction_id = "$redaction_event_id"
|
|
|
|
event = make_test_event(
|
|
type="foo",
|
|
event_id="test",
|
|
room_id="!foo:bar",
|
|
content={"foo": "bar"},
|
|
)
|
|
event.internal_metadata.redacted_by = redaction_id
|
|
|
|
redaction_event = make_test_event(
|
|
type="m.room.redaction",
|
|
event_id=redaction_id,
|
|
content={"redacts": "test"},
|
|
)
|
|
|
|
self.assertEqual(
|
|
self.serialize(
|
|
event,
|
|
["content.foo"],
|
|
redaction_map={redaction_id: redaction_event},
|
|
),
|
|
{
|
|
"content": {"foo": "bar"},
|
|
},
|
|
)
|
|
|
|
self.assertEqual(
|
|
self.serialize(
|
|
event,
|
|
["content.foo", "unsigned.redacted_because"],
|
|
redaction_map={redaction_id: redaction_event},
|
|
),
|
|
{
|
|
"content": {"foo": "bar"},
|
|
"unsigned": {
|
|
"redacted_because": self.serialize(redaction_event, fields=None),
|
|
},
|
|
},
|
|
)
|
|
|
|
|
|
class CopyPowerLevelsContentTestCase(stdlib_unittest.TestCase):
|
|
def setUp(self) -> None:
|
|
self.test_content: PowerLevelsContent = {
|
|
"ban": 50,
|
|
"events": {"m.room.name": 100, "m.room.power_levels": 100},
|
|
"events_default": 0,
|
|
"invite": 50,
|
|
"kick": 50,
|
|
"notifications": {"room": 20},
|
|
"redact": 50,
|
|
"state_default": 50,
|
|
"users": {"@example:localhost": 100},
|
|
"users_default": 0,
|
|
}
|
|
|
|
def _test(self, input: PowerLevelsContent) -> None:
|
|
a = copy_and_fixup_power_levels_contents(input)
|
|
|
|
self.assertEqual(a["ban"], 50)
|
|
assert isinstance(a["events"], Mapping)
|
|
self.assertEqual(a["events"]["m.room.name"], 100)
|
|
|
|
# make sure that changing the copy changes the copy and not the orig
|
|
a["ban"] = 10
|
|
a["events"]["m.room.power_levels"] = 20
|
|
|
|
self.assertEqual(input["ban"], 50)
|
|
assert isinstance(input["events"], Mapping)
|
|
self.assertEqual(input["events"]["m.room.power_levels"], 100)
|
|
|
|
def test_unfrozen(self) -> None:
|
|
self._test(self.test_content)
|
|
|
|
def test_frozen(self) -> None:
|
|
input = freeze(self.test_content)
|
|
self._test(input)
|
|
|
|
def test_stringy_integers(self) -> None:
|
|
"""String representations of decimal integers are converted to integers."""
|
|
input: PowerLevelsContent = {
|
|
"a": "100",
|
|
"b": {
|
|
"foo": 99,
|
|
"bar": "-98",
|
|
},
|
|
"d": "0999",
|
|
}
|
|
output = copy_and_fixup_power_levels_contents(input)
|
|
expected_output = {
|
|
"a": 100,
|
|
"b": {
|
|
"foo": 99,
|
|
"bar": -98,
|
|
},
|
|
"d": 999,
|
|
}
|
|
|
|
self.assertEqual(output, expected_output)
|
|
|
|
def test_strings_that_dont_represent_decimal_integers(self) -> None:
|
|
"""Should raise when given inputs `s` for which `int(s, base=10)` raises."""
|
|
for invalid_string in ["0x123", "123.0", "123.45", "hello", "0b1", "0o777"]:
|
|
with self.assertRaises(TypeError):
|
|
copy_and_fixup_power_levels_contents({"a": invalid_string})
|
|
|
|
def test_invalid_types_raise_type_error(self) -> None:
|
|
with self.assertRaises(TypeError):
|
|
copy_and_fixup_power_levels_contents({"a": ["hello", "grandma"]}) # type: ignore[dict-item]
|
|
copy_and_fixup_power_levels_contents({"a": None}) # type: ignore[dict-item]
|
|
|
|
def test_invalid_nesting_raises_type_error(self) -> None:
|
|
with self.assertRaises(TypeError):
|
|
copy_and_fixup_power_levels_contents({"a": {"b": {"c": 1}}}) # type: ignore[dict-item]
|
|
|
|
|
|
class SplitFieldTestCase(stdlib_unittest.TestCase):
|
|
@parameterized.expand(
|
|
[
|
|
# A field with no dots.
|
|
["m", ["m"]],
|
|
# Simple dotted fields.
|
|
["m.foo", ["m", "foo"]],
|
|
["m.foo.bar", ["m", "foo", "bar"]],
|
|
# Backslash is used as an escape character.
|
|
[r"m\.foo", ["m.foo"]],
|
|
[r"m\\.foo", ["m\\", "foo"]],
|
|
[r"m\\\.foo", [r"m\.foo"]],
|
|
[r"m\\\\.foo", ["m\\\\", "foo"]],
|
|
[r"m\foo", [r"m\foo"]],
|
|
[r"m\\foo", [r"m\foo"]],
|
|
[r"m\\\foo", [r"m\\foo"]],
|
|
[r"m\\\\foo", [r"m\\foo"]],
|
|
# Ensure that escapes at the end don't cause issues.
|
|
["m.foo\\", ["m", "foo\\"]],
|
|
["m.foo\\", ["m", "foo\\"]],
|
|
[r"m.foo\.", ["m", "foo."]],
|
|
[r"m.foo\\.", ["m", "foo\\", ""]],
|
|
[r"m.foo\\\.", ["m", r"foo\."]],
|
|
# Empty parts (corresponding to properties which are an empty string) are allowed.
|
|
[".m", ["", "m"]],
|
|
["..m", ["", "", "m"]],
|
|
["m.", ["m", ""]],
|
|
["m..", ["m", "", ""]],
|
|
["m..foo", ["m", "", "foo"]],
|
|
# Invalid escape sequences.
|
|
[r"\m", [r"\m"]],
|
|
]
|
|
)
|
|
def test_split_field(self, input: str, expected: str) -> None:
|
|
self.assertEqual(_split_field(input), expected)
|