synapse/changelog.d/20422.bugfix at ee91c5fff0e1a60d0e218a94ee4c8dfd202caa3a - synapse - Gitea: Git with a cup of tea

dandri/synapse

0 Fork 0

mirror of https://github.com/element-hq/synapse.git synced 2026-11-04 11:17:51 +00:00

Files

T

Jason Robinson ee3fc37345 Partially revert "Reject setting null profile field values" (#20422 )

As per https://github.com/element-hq/synapse/issues/20419 this change
broke Element Web clearing user status, which basically means the client
is stuck with any status, and users cannot set a new one.

EW should move to use DELETE to clear user status, but until then we
should ensure the feature is not broken on existing clients in the wild.

Should we set a clear deprecation time for rejecting nulls? There might
be other clients using profile fields and doing PUT to clear the field.


Discussed in
[`#element-backend-internal:matrix.org`](https://matrix.to/#/!SGNQGPGUwtcPBUotTL:matrix.org/$b7zid3lLGdFDC8pwy1IvSPv3zl9y1fXEpnnBte9vcQU?via=jki.re&via=element.io&via=matrix.org)
[[1]](https://matrix.to/#/!SGNQGPGUwtcPBUotTL:matrix.org/$jTEcHlDBIvKRAKtV-ESXabkPkLia9B7C4JQVkoOxzj0?via=jki.re&via=element.io&via=matrix.org)

Reverts a part of https://github.com/element-hq/synapse/pull/20153 by
only rejecting null fields when the profile update stream is configured
(ie user status requirement).

Future work to unrevert tracked by
https://github.com/element-hq/synapse/issues/20424

2026-10-28 11:34:02 -05:00

4 lines

363 B

Plaintext

Raw Blame History

 Fix clearing user status for clients that send a `null` profile field value.
 When `include_profile_updates_in_sync` is enabled, Synapse will continue to accept `null` custom profile field values
 until clients have had a sufficient time to change their behaviour. This special casing is tracked in [this issue](https://github.com/element-hq/synapse/issues/20424).