mirror of
https://github.com/element-hq/synapse.git
synced 2026-10-24 19:23:21 +00:00
7d44c81d5c
> [!NOTE] > This PR will be rebased on `develop` once https://github.com/element-hq/synapse/pull/20081 is merged This PR is a follow up to https://github.com/element-hq/synapse/pull/20081 and is based on its code. The scope of that original PR is limited to recovering the leave event missing from `state_after`. I noticed that state events from the leave event batch would only be recovered if they were previously defined. That made me add a pre-condition to the test: the topic had to be set first. https://github.com/element-hq/synapse/blob/bccf1679aed0a5d86de87165c548f8c459758055/tests/handlers/test_sync.py#L1096-L1099 This PR attempts to recover new state events that only appeared first in the leave batch. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: Fefaine <fefaine@gmail.com> Co-authored-by: Quentin Gliech <quenting@element.io> Co-authored-by: Eric Eastwood <madlittlemods@gmail.com> Co-authored-by: Eric Eastwood <erice@element.io>