dandri/unleashed-firmware

Fork 0

mirror of https://github.com/DarkFlippers/unleashed-firmware.git synced 2026-08-21 10:29:50 +00:00

Files

T

History

b90057e472 NFC: say what became of an Ultralight authentication (#1090 )

Auth failed and auth never attempted produced the same read-success
screen, and they are opposites in cost - one can spend an attempt the
card counts, the other deliberately spends nothing. A user who cannot
tell them apart retries, which on an AUTHLIM card is how it gets locked
for good.

MfUltralightPollerEventTypeAuthFailed had exactly one consumer in the
tree, the CLI dump command; the GUI ignored it. Handle it, record the
outcome, and render a line for it on the read result. Only user-driven
auth reaches that event - the poller's default-password probe
authenticates directly and emits nothing - so it cannot fire on a plain
read. The skipped case comes from #1086: a UID the Amiibo/Xiaomi
generator cannot derive a password from now says so.

The wording stays conditional ("cards with an auth limit counted this
attempt") because AUTHLIM is frequently 0, in which case a failed
PWD_AUTH costs nothing - and per #1089 it is often unreadable anyway.

The outcome is cleared by whoever starts a read, not by
mf_ultralight_auth_reset(). That reset scrubs credentials and runs after
the result is drawn, so hanging the outcome off it would have wiped the
banner on any re-entry - Retry then Stay, or More then Back, both
re-run the scene's on_enter - and would have left a stale verdict for
the dictionary-attack scenes, which reach the same screen without
touching the unlock helper. A failed unlock followed by a successful
dictionary attack would have reported "auth failed" over unlocked data.

Also stop the unlock screen printing a password it does not have.
nfc_render_mf_ultralight_pwd_pack() rendered PWD/PACK whenever the card
type has a config page, but those pages read back masked as zero when
auth did not succeed, so a failed unlock displayed
"Password: 00 00 00 00" as though recovered. Its sibling _if_read()
already gated on mf_ultralight_is_pwd_pack_read(); this one now does too.

MfUltralightAuth gained a field and protocol plugins dereference it, so
the plugin API version goes to 3.

Not covered, and unchanged by this: UL-C 3DES unlocks still report
nothing either way, because that poller handler raises neither
AuthSuccess nor AuthFailed in read mode.

Closes #1088

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-21 00:48:07 +03:00

debug

Merge remote-tracking branch 'OFW/dev' into dev

2026-08-03 10:08:56 +03:00

drivers

SubGHz: Add FSK12Kdev modulation and Cardin S449 Keeloq support (#4328 )

2026-06-30 22:14:56 +03:00

examples

fbt format

2026-08-16 15:32:31 +03:00

main

NFC: say what became of an Ultralight authentication (#1090 )