From 1eaa2f3e759351bc746dec2ccc57b92cdcf1b5d7 Mon Sep 17 00:00:00 2001 From: rhysfred Date: Mon, 5 Jan 2026 05:51:46 +1100 Subject: [PATCH] fix: Log error before renaming failed to load converters (#30436) Co-authored-by: rhys --- lib/extension/externalJS.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/extension/externalJS.ts b/lib/extension/externalJS.ts index 569d395d..119a18c9 100644 --- a/lib/extension/externalJS.ts +++ b/lib/extension/externalJS.ts @@ -202,14 +202,14 @@ export default abstract class ExternalJSExtension extends Extension { const mod = await this.importFile(filePath); await this.loadJS(extension.name, mod.default); } catch (error) { - // change ext so Z2M doesn't try to load it again and again - fs.renameSync(filePath, `${filePath}.invalid`); - logger.error( `Invalid external ${this.mqttTopic} '${extension.name}' was ignored and renamed to prevent interference with Zigbee2MQTT. (${(error as Error).message})`, ); // biome-ignore lint/style/noNonNullAssertion: always Error logger.debug((error as Error).stack!); + + // change ext so Z2M doesn't try to load it again and again + fs.renameSync(filePath, `${filePath}.invalid`); } } }