From 267c3990474dcc646e6987a108867a54b8b940db Mon Sep 17 00:00:00 2001 From: clockbrain <40568549+clockbrain@users.noreply.github.com> Date: Thu, 27 Mar 2025 06:45:33 +1000 Subject: [PATCH] fix: Add device name to no converter available error message (#26867) --- lib/extension/publish.ts | 2 +- test/extensions/publish.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/extension/publish.ts b/lib/extension/publish.ts index fde7ac340..19e47f0dc 100644 --- a/lib/extension/publish.ts +++ b/lib/extension/publish.ts @@ -212,7 +212,7 @@ export default class Publish extends Extension { } if (!converter) { - logger.error(`No converter available for '${key}' (${stringify(message[key])})`); + logger.error(`No converter available for '${key}' on '${re.name}': (${stringify(message[key])})`); continue; } diff --git a/test/extensions/publish.test.ts b/test/extensions/publish.test.ts index ad43ca476..b509db877 100644 --- a/test/extensions/publish.test.ts +++ b/test/extensions/publish.test.ts @@ -628,7 +628,7 @@ describe('Extension: Publish', () => { mockLogger.error.mockClear(); await mockMQTTEvents.message('zigbee2mqtt/0x0017880104e45542/get', stringify({state_center: '', state_right: ''})); await flushPromises(); - expect(mockLogger.error).toHaveBeenCalledWith(`No converter available for 'state_center' ("")`); + expect(mockLogger.error).toHaveBeenCalledWith(`No converter available for 'state_center' on 'wall_switch_double': ("")`); expect(endpoint2.read).toHaveBeenCalledTimes(0); expect(endpoint3.read).toHaveBeenCalledTimes(1); expect(endpoint3.read).toHaveBeenCalledWith('genOnOff', ['onOff']);