From 344b6e03b43644c97154a72ca9eae17193c553a2 Mon Sep 17 00:00:00 2001 From: Koen Kanters Date: Fri, 2 Oct 2026 07:57:23 +0200 Subject: [PATCH] chore: fix release-please generate bogus changelog when release has not yet been released --- .github/workflows/release-please.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index ec2500958..49257343e 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -48,7 +48,19 @@ jobs: key: commit-user-lookup-dummy restore-keys: | commit-user-lookup- + # When a release PR is merged, the release is created as draft (no tag yet) until it is published. + # In that window release-please cannot find the latest release and generates a changelog containing old commits. + - name: Check for unpublished release + id: pending + run: | + VERSION=$(jq -r '."."' z2m/.release-please-manifest.json) + if git -C z2m ls-remote --exit-code --tags origin "refs/tags/$VERSION" > /dev/null; then + echo "pending=false" >> $GITHUB_OUTPUT + else + echo "pending=true" >> $GITHUB_OUTPUT + fi - name: Generate changelog + if: steps.pending.outputs.pending == 'false' run: | MASTER_Z2M_VERSION=$(cat z2m-master/package.json | jq -r '.version') MASTER_ZHC_VERSION=$(cat z2m-master/package.json | jq -r '.dependencies."zigbee-herdsman-converters"') @@ -62,6 +74,7 @@ jobs: env: GH_TOKEN: ${{secrets.GH_TOKEN}} - name: Update changelog gist + if: steps.pending.outputs.pending == 'false' run: | gh gist edit bfd4c3d1725a2cccacc11d6ba51008ba -a changelog.md env: