From 1ea7f650a23f517177a2ec51278ad58369d61ab9 Mon Sep 17 00:00:00 2001
From: Koen Kanters <koenkanters94@gmail.com>
Date: Mon, 27 Oct 2025 20:43:11 +0100
Subject: [PATCH] chore: fix external converter/new device support bot

---
 .../new_device_external_converter_bot.yml     | 58 +++++++++----------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/.github/workflows/new_device_external_converter_bot.yml b/.github/workflows/new_device_external_converter_bot.yml
index 552bca1ea..2f01b230e 100644
--- a/.github/workflows/new_device_external_converter_bot.yml
+++ b/.github/workflows/new_device_external_converter_bot.yml
@@ -96,35 +96,35 @@ jobs:
                       return;
                     }
                 }
-            }
-
-            // Check if zigbee model is already supported.
-            const zigbeeModelRe = /zigbeeModel: \[['"](.+)['"]\]/g;
-            const zigbeeModels = Array.from(issue.body.matchAll(zigbeeModelRe), m => m[1]);
-            if (zigbeeModels.length > 0) {
-              for (const zigbeeModel of zigbeeModels) {
-                const fullMatch = (() => { try { return execSync(`grep -r --include="*.ts" '"${zigbeeModel}"' zhc`, {encoding: 'utf8'}); } catch { return undefined; } })();
-                if (fullMatch) {
-                  await github.rest.issues.createComment({
-                    owner: context.repo.owner,
-                    repo: context.repo.repo,
-                    issue_number: issue.number,
-                    body: [
-                      `👋 Hi there! The device with zigbee model \`${zigbeeModel}\` is already supported in the latest dev branch.`,
-                      "See this [guide](https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html) on how to update, after updating you can remove your external converter.",
-                      "",
-                      "In case you created the external converter with the goal to extend or fix an issue with the out-of-the-box support, please submit a pull request.",
-                      "For instructions on how to create a pull request see the [docs](https://www.zigbee2mqtt.io/advanced/support-new-devices/01_support_new_devices.html#_4-create-a-pull-request).",
-                      "If you need help with the process, feel free to ask here and we'll be happy to assist."
-                    ].join('\n')
-                  });
-                  await github.rest.issues.update({
-                    owner: context.repo.owner,
-                    repo: context.repo.repo,
-                    issue_number: issue.number,
-                    state: "closed",
-                  });
-                  return;
+            } else {
+              // Check if zigbee model is already supported.
+              const zigbeeModelRe = /zigbeeModel: \[['"](.+)['"]\]/g;
+              const zigbeeModels = Array.from(issue.body.matchAll(zigbeeModelRe), m => m[1]);
+              if (zigbeeModels.length > 0) {
+                for (const zigbeeModel of zigbeeModels) {
+                  const fullMatch = (() => { try { return execSync(`grep -r --include="*.ts" '"${zigbeeModel}"' zhc`, {encoding: 'utf8'}); } catch { return undefined; } })();
+                  if (fullMatch) {
+                    await github.rest.issues.createComment({
+                      owner: context.repo.owner,
+                      repo: context.repo.repo,
+                      issue_number: issue.number,
+                      body: [
+                        `👋 Hi there! The device with zigbee model \`${zigbeeModel}\` is already supported in the latest dev branch.`,
+                        "See this [guide](https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html) on how to update, after updating you can remove your external converter.",
+                        "",
+                        "In case you created the external converter with the goal to extend or fix an issue with the out-of-the-box support, please submit a pull request.",
+                        "For instructions on how to create a pull request see the [docs](https://www.zigbee2mqtt.io/advanced/support-new-devices/01_support_new_devices.html#_4-create-a-pull-request).",
+                        "If you need help with the process, feel free to ask here and we'll be happy to assist."
+                      ].join('\n')
+                    });
+                    await github.rest.issues.update({
+                      owner: context.repo.owner,
+                      repo: context.repo.repo,
+                      issue_number: issue.number,
+                      state: "closed",
+                    });
+                    return;
+                  }
                 }
               }
             }