fix: Fix crash on a null color in attribute output (#32784)

This commit is contained in:
Luan Taraschi
2026-08-08 21:27:36 +02:00
committed by GitHub
parent 046817624f
commit 3aaa8c1546
2 changed files with 15 additions and 1 deletions
+4 -1
View File
@@ -465,7 +465,10 @@ export class Controller {
let message: string | undefined;
// Special cases
if (key === "color" && utils.objectHasProperties(subPayload, ["r", "g", "b"])) {
// `objectHasProperties` indexes its argument, so it has to be given an object.
// The null check three lines below is too late: `color` is nullable like any
// other attribute, and a null one reaches here before that branch runs.
if (key === "color" && subPayload != null && utils.objectHasProperties(subPayload, ["r", "g", "b"])) {
subPayload = [subPayload.r, subPayload.g, subPayload.b];
}