From 3f6a95bc0be9381ea17239dcc294ac7bf536e889 Mon Sep 17 00:00:00 2001
From: Koen Kanters <koenkanters94@gmail.com>
Date: Thu, 16 Jan 2020 22:52:13 +0100
Subject: [PATCH] Don't setup reporting for BASICZBR3 as it doesn't support it.
 #2740

---
 lib/extension/deviceReport.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/extension/deviceReport.js b/lib/extension/deviceReport.js
index 466d9745..604c2c88 100644
--- a/lib/extension/deviceReport.js
+++ b/lib/extension/deviceReport.js
@@ -1,6 +1,7 @@
 const zigbeeHerdsmanConverters = require('zigbee-herdsman-converters');
 const logger = require('../util/logger');
 const CC2530Router = zigbeeHerdsmanConverters.devices.find((d) => d.model === 'CC2530.ROUTER');
+const BASICZBR3 = zigbeeHerdsmanConverters.devices.find((d) => d.model === 'BASICZBR3');
 const ZNLDP12LM = zigbeeHerdsmanConverters.devices.find((d) => d.model === 'ZNLDP12LM');
 const utils = require('../util/utils');
 const BaseExtension = require('./baseExtension');
@@ -11,6 +12,8 @@ const defaultConfiguration = {
     minimumReportInterval: 3, maximumReportInterval: 300, reportableChange: 1,
 };
 
+const devicesNotSupportingReporting = [CC2530Router, BASICZBR3];
+
 const reportKey = 1;
 
 const clusters = {
@@ -120,7 +123,7 @@ class DeviceReport extends BaseExtension {
         if (device.meta.hasOwnProperty('reporting') && device.meta.reporting === reportKey) return false;
         if (!utils.isRouter(device) || utils.isBatteryPowered(device)) return false;
         // Gledopto devices don't support reporting.
-        if (mappedDevice === CC2530Router || mappedDevice.vendor === 'Gledopto') return false;
+        if (devicesNotSupportingReporting.includes(mappedDevice) || mappedDevice.vendor === 'Gledopto') return false;
         return true;
     }