From 7e2a2bdd34b24d898011fcfa5fc766a18d1c47f1 Mon Sep 17 00:00:00 2001 From: Koen Kanters Date: Sun, 14 Nov 2021 16:04:23 +0100 Subject: [PATCH] Remove led control (#9404) --- lib/zigbee.ts | 5 ----- test/controller.test.js | 8 -------- test/stub/zigbeeHerdsman.js | 1 - 3 files changed, 14 deletions(-) diff --git a/lib/zigbee.ts b/lib/zigbee.ts index 89cbeacc0..22a648df5 100644 --- a/lib/zigbee.ts +++ b/lib/zigbee.ts @@ -128,11 +128,6 @@ export default class Zigbee { } } - // Check if we have to turn off the led - if (settings.get().serial.disable_led) { - await this.herdsman.setLED(false); - } - // Check if we have to set a transmit power if (settings.get().experimental.hasOwnProperty('transmit_power')) { const transmitPower = settings.get().experimental.transmit_power; diff --git a/test/controller.test.js b/test/controller.test.js index afa291c8a..95e3665b6 100644 --- a/test/controller.test.js +++ b/test/controller.test.js @@ -43,7 +43,6 @@ describe('Controller', () => { await controller.start(); expect(zigbeeHerdsman.constructor).toHaveBeenCalledWith({"network":{"panID":6754,"extendedPanID":[221,221,221,221,221,221,221,221],"channelList":[11],"networkKey":[1,3,5,7,9,11,13,15,0,2,4,6,8,10,12,13]},"databasePath":path.join(data.mockDir, "database.db"), "databaseBackupPath":path.join(data.mockDir, "database.db.backup"),"backupPath":path.join(data.mockDir, "coordinator_backup.json"),"acceptJoiningDeviceHandler": expect.any(Function),adapter: {concurrent: null, delay: null, disableLED: false}, "serialPort":{"baudRate":undefined,"rtscts":undefined,"path":"/dev/dummy"}}, logger); expect(zigbeeHerdsman.start).toHaveBeenCalledTimes(1); - expect(zigbeeHerdsman.setLED).toHaveBeenCalledTimes(0); expect(zigbeeHerdsman.setTransmitPower).toHaveBeenCalledTimes(0); expect(zigbeeHerdsman.permitJoin).toHaveBeenCalledTimes(1); expect(zigbeeHerdsman.permitJoin).toHaveBeenCalledWith(true, undefined, undefined); @@ -229,13 +228,6 @@ describe('Controller', () => { expect(zigbeeHerdsman.permitJoin).toHaveBeenCalledWith(false, undefined, undefined); }); - it('Start controller with disable_led', async () => { - settings.set(['serial', 'disable_led'], true); - await controller.start(); - expect(zigbeeHerdsman.setLED).toHaveBeenCalledTimes(1); - expect(zigbeeHerdsman.setLED).toHaveBeenCalledWith(false); - }); - it('Start controller with transmit power', async () => { settings.set(['experimental', 'transmit_power'], 14); await controller.start(); diff --git a/test/stub/zigbeeHerdsman.js b/test/stub/zigbeeHerdsman.js index 1d2b7ff17..7a58c5f0a 100644 --- a/test/stub/zigbeeHerdsman.js +++ b/test/stub/zigbeeHerdsman.js @@ -215,7 +215,6 @@ const mock = { events[type] = handler; }, stop: jest.fn(), - setLED: jest.fn(), getDevices: jest.fn().mockImplementation(() => { return Object.values(devices).filter((d) => returnDevices.length === 0 || returnDevices.includes(d.ieeeAddr)); }),