From 95279b02afe87788c2080ad7b9b2df2c5cbb5f7b Mon Sep 17 00:00:00 2001 From: Koen Kanters Date: Sat, 9 Nov 2024 14:55:44 +0100 Subject: [PATCH] fix(ignore): Small cleanup (#24696) --- lib/extension/externalConverters.ts | 4 +--- test/assets/mock-external-converter-multiple.js | 12 ------------ test/extensions/homeassistant.test.ts | 1 - 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/extension/externalConverters.ts b/lib/extension/externalConverters.ts index 598d59a37..06d4e7789 100644 --- a/lib/extension/externalConverters.ts +++ b/lib/extension/externalConverters.ts @@ -21,9 +21,7 @@ export default class ExternalConverters extends Extension { for (const file of settings.get().external_converters) { try { for (const definition of loadExternalConverter(file)) { - const toAdd = {...definition}; - delete toAdd['homeassistant']; - zhc.addDefinition(toAdd); + zhc.addDefinition(definition); } logger.info(`Loaded external converter '${file}'`); } catch (error) { diff --git a/test/assets/mock-external-converter-multiple.js b/test/assets/mock-external-converter-multiple.js index d48543f7d..264e7fc73 100644 --- a/test/assets/mock-external-converter-multiple.js +++ b/test/assets/mock-external-converter-multiple.js @@ -1,19 +1,7 @@ -const homeassistantSwitch = { - type: 'switch', - object_id: 'switch', - discovery_payload: { - payload_off: 'OFF', - payload_on: 'ON', - value_template: '{{ value_json.state }}', - command_topic: true, - }, -}; - const mockDevices = [ { mock: 1, model: 'external_converters_device_1', - homeassistant: [homeassistantSwitch], zigbeeModel: ['external_converter_device_1'], vendor: 'external_1', description: 'external_1', diff --git a/test/extensions/homeassistant.test.ts b/test/extensions/homeassistant.test.ts index 59a4eb84e..16f66b7d2 100644 --- a/test/extensions/homeassistant.test.ts +++ b/test/extensions/homeassistant.test.ts @@ -1847,7 +1847,6 @@ describe('Extension: HomeAssistant', () => { it('Should enable experimental event entities', async () => { settings.set(['homeassistant'], {experimental_event_entities: true}); settings.set(['devices', '0x0017880104e45520'], { - legacy: false, friendly_name: 'button', retain: false, });