Fix Test Linting

apps/draupnir/src/appservice/AppServiceDraupnirManager.ts

@@ -49,7 +49,11 @@ import {
   userLocalpart,
 } from "@the-draupnir-project/matrix-basic-types";
 import { TopLevelStores } from "../backingstore/DraupnirStores";
-import { loadOrCreateZeroTouchDeployRoom, ZERO_TOUCH_DEPLOY_ROOM_ACCOUNT_DATA_TYPE, ZeroTouchDeployRoomAccountDataSchema } from "../managedRoomAccountData";
+import {
+  loadOrCreateZeroTouchDeployRoom,
+  ZERO_TOUCH_DEPLOY_ROOM_ACCOUNT_DATA_TYPE,
+  ZeroTouchDeployRoomAccountDataSchema,
+} from "../managedRoomAccountData";
 
 const log = new Logger("AppServiceDraupnirManager");
 

apps/draupnir/src/protections/TrustedReporters.ts

@@ -194,15 +194,12 @@ export class TrustedReporters
     }
 
     if (met.length > 0) {
-      await this.draupnir.client.sendMessage(
-        this.draupnir.managementRoomID,
-        {
-          msgtype: "m.notice",
-          body:
-            `message ${report.event_id} reported by ${[...reporters].join(", ")}. ` +
-            `actions: ${met.join(", ")}`,
-        }
-      );
+      await this.draupnir.client.sendMessage(this.draupnir.managementRoomID, {
+        msgtype: "m.notice",
+        body:
+          `message ${report.event_id} reported by ${[...reporters].join(", ")}. ` +
+          `actions: ${met.join(", ")}`,
+      });
     }
     return Ok(undefined);
   }

apps/draupnir/test/appservice/integration/managedBootstrapStartTest.ts

@@ -14,13 +14,18 @@ describe("Managed room bootstrap startup integration", function (this: Mocha.Sui
     const initialManager = await newTestUser(config.homeserver.url, {
       name: { contains: "managed-admin" },
     });
-    config.managedAdminRoom = true;
-    config.adminRoom = undefined;
-    config.initialManager = (await initialManager.getUserId()) as StringUserID;
+    const testConfigRecord = {
+      ...(config as unknown as Record<string, unknown>),
+    };
+    testConfigRecord.managedAdminRoom = true;
+    testConfigRecord.adminRoom = undefined;
+    testConfigRecord.initialManager =
+      (await initialManager.getUserId()) as StringUserID;
+    const testConfig = testConfigRecord as typeof config;
 
     let appservice: MjolnirAppService | undefined;
     try {
-      appservice = await setupHarnessWithConfig(config, {
+      appservice = await setupHarnessWithConfig(testConfig, {
         ensureAdminRoomAlias: false,
       });
       if (appservice.accessControlRoomID.length === 0) {

apps/draupnir/test/integration/commands/redactCommandTest.ts

@@ -51,6 +51,9 @@ describe("Test: The redaction command", function () {
         name: { contains: "moderator" },
       });
       this.moderator = moderator;
+      if (this.config.managementRoom === undefined) {
+        throw new TypeError("managementRoom is required for this test");
+      }
       await moderator.joinRoom(this.config.managementRoom);
       const targetRoom = await moderator.createRoom({
         invite: [await badUser.getUserId(), mjolnirUserId],
@@ -158,6 +161,9 @@ describe("Test: The redaction command", function () {
         name: { contains: "moderator" },
       });
       this.moderator = moderator;
+      if (this.config.managementRoom === undefined) {
+        throw new TypeError("managementRoom is required for this test");
+      }
       await moderator.joinRoom(this.config.managementRoom);
       const targetRooms: string[] = [];
       for (let i = 0; i < 5; i++) {
@@ -260,6 +266,9 @@ describe("Test: The redaction command", function () {
       name: { contains: "moderator" },
     });
     this.moderator = moderator;
+    if (this.config.managementRoom === undefined) {
+      throw new TypeError("managementRoom is required for this test");
+    }
     await moderator.joinRoom(this.config.managementRoom);
     const targetRoom = await moderator.createRoom({
       invite: [await badUser.getUserId(), draupnir.clientUserID],

apps/draupnir/test/integration/commands/roomsTest.ts

@@ -36,6 +36,9 @@ describe("Test: The rooms commands", function () {
         name: { contains: "moderator" },
       });
       this.moderator = moderator;
+      if (this.config.managementRoom === undefined) {
+        throw new TypeError("managementRoom is required for this test");
+      }
       await moderator.joinRoom(this.config.managementRoom);
       const targetRoom = await moderator.createRoom({
         invite: [draupnir.clientUserID],

apps/draupnir/test/integration/fixtures.ts

@@ -81,7 +81,9 @@ export const mochaHooks = {
       this.timeout(30000);
       this.lifetime = new StandardLifetime();
       const config = (this.config = configRead());
-      this.managementRoomAlias = config.managementRoom;
+      if (config.managementRoom !== undefined) {
+        this.managementRoomAlias = config.managementRoom;
+      }
       const storagePath = getStoragePath(config.dataPath);
       await cleanUpTopLevelStores(storagePath);
       this.stores = makeTopLevelStores(storagePath, DefaultEventDecoder, {

apps/draupnir/test/integration/helloTest.ts

@@ -38,6 +38,9 @@ describe("Test: !help command", function (this: Mocha.Suite) {
     if (draupnir === undefined) {
       throw new TypeError(`setup code is wrong`);
     }
+    if (this.config.managementRoom === undefined) {
+      throw new TypeError("managementRoom is required for this test");
+    }
     await client.joinRoom(this.config.managementRoom);
     // listener for getting the event reply
     const reply = new Promise((resolve) => {

apps/draupnir/test/integration/mjolnirSetupUtils.ts

@@ -34,7 +34,10 @@ import {
 } from "matrix-protection-suite";
 import { SafeModeDraupnir } from "../../src/safemode/DraupnirSafeMode";
 import { TopLevelStores } from "../../src/backingstore/DraupnirStores";
-import { isStringUserID, userLocalpart } from "@the-draupnir-project/matrix-basic-types";
+import {
+  isStringUserID,
+  userLocalpart,
+} from "@the-draupnir-project/matrix-basic-types";
 
 patchMatrixClient();
 

apps/draupnir/test/integration/utilsTest.ts

@@ -21,6 +21,9 @@ describe("Test: utils", function () {
   it(
     "replaceRoomIdsWithPills correctly turns a room ID in to a pill",
     async function (this: DraupnirTestContext) {
+      if (this.config.managementRoom === undefined) {
+        throw new TypeError("managementRoom is required for this test");
+      }
       const managementRoomAlias = this.config.managementRoom;
       const draupnir = this.draupnir;
       const draupnirMatrixClient = draupnirSafeEmitter();