mirror of
https://git.quad4.io/RNS-Things/MeshChatX.git
synced 2026-04-25 17:32:09 +00:00
test(lxmf): add comprehensive tests for LXMF sieve filter functions
This commit is contained in:
Ivan
234
tests/backend/test_lxmf_sieve.py
Normal file
234
tests/backend/test_lxmf_sieve.py
Normal file
@@ -0,0 +1,234 @@
|
||||
# SPDX-License-Identifier: 0BSD
|
||||
|
||||
from meshchatx.src.backend.lxmf_sieve import (
|
||||
first_matching_lxmf_sieve_rule,
|
||||
normalize_lxmf_sieve_filters,
|
||||
parse_lxmf_sieve_filters_json,
|
||||
)
|
||||
|
||||
|
||||
def test_parse_empty_and_invalid():
|
||||
assert parse_lxmf_sieve_filters_json(None) == []
|
||||
assert parse_lxmf_sieve_filters_json("") == []
|
||||
assert parse_lxmf_sieve_filters_json("not json") == []
|
||||
assert parse_lxmf_sieve_filters_json("{}") == []
|
||||
|
||||
|
||||
def test_normalize_drops_bad_and_keeps_good():
|
||||
raw = [
|
||||
{"action": "nope", "terms": ["x"]},
|
||||
{"action": "ignore", "terms": ["spam"], "enabled": True, "id": "a1"},
|
||||
{"action": "folder", "terms": ["work"], "folder_id": 3, "id": "b2"},
|
||||
{"action": "folder", "terms": ["bad"], "folder_id": "nan"},
|
||||
]
|
||||
out = normalize_lxmf_sieve_filters(raw)
|
||||
assert len(out) == 2
|
||||
assert out[0]["action"] == "ignore"
|
||||
assert out[0]["terms"] == ["spam"]
|
||||
assert out[0]["scope"] == "everyone"
|
||||
assert out[0]["match_peer_fields"] is True
|
||||
assert out[0]["match_message"] is False
|
||||
assert out[0]["match_mode"] == "substring"
|
||||
assert out[1]["action"] == "folder"
|
||||
assert out[1]["folder_id"] == 3
|
||||
assert out[1]["scope"] == "everyone"
|
||||
|
||||
|
||||
def test_normalize_drops_when_both_match_targets_disabled():
|
||||
assert (
|
||||
normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "ignore",
|
||||
"terms": ["a"],
|
||||
"match_peer_fields": False,
|
||||
"match_message": False,
|
||||
},
|
||||
],
|
||||
)
|
||||
== []
|
||||
)
|
||||
|
||||
|
||||
def test_first_match_respects_order_and_enabled():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{"action": "ignore", "terms": ["foo"], "enabled": True},
|
||||
{"action": "hide", "terms": ["foo"], "enabled": True},
|
||||
],
|
||||
)
|
||||
m = first_matching_lxmf_sieve_rule(rules, "Mr foo bar")
|
||||
assert m["action"] == "ignore"
|
||||
|
||||
rules2 = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{"action": "ignore", "terms": ["foo"], "enabled": False},
|
||||
{"action": "block", "terms": ["foo"], "enabled": True},
|
||||
],
|
||||
)
|
||||
m2 = first_matching_lxmf_sieve_rule(rules2, "Mr foo bar")
|
||||
assert m2["action"] == "hide"
|
||||
|
||||
|
||||
def test_legacy_block_action_normalizes_to_hide():
|
||||
rules = normalize_lxmf_sieve_filters([{"action": "block", "terms": ["z"]}])
|
||||
assert rules[0]["action"] == "hide"
|
||||
|
||||
|
||||
def test_case_insensitive_substring():
|
||||
rules = normalize_lxmf_sieve_filters([{"action": "hide", "terms": ["SpAm"]}])
|
||||
assert first_matching_lxmf_sieve_rule(rules, "user spammer")["action"] == "hide"
|
||||
assert first_matching_lxmf_sieve_rule(rules, "USER") is None
|
||||
|
||||
|
||||
def test_parse_json_roundtrip():
|
||||
s = '[{"id":"1","enabled":true,"terms":["a"],"action":"ignore","folder_id":null}]'
|
||||
got = parse_lxmf_sieve_filters_json(s)
|
||||
assert len(got) == 1
|
||||
assert got[0]["terms"] == ["a"]
|
||||
assert got[0]["scope"] == "everyone"
|
||||
|
||||
|
||||
def test_normalize_preserves_scope():
|
||||
out = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{"action": "ignore", "terms": ["x"], "scope": "contacts"},
|
||||
{"action": "hide", "terms": ["y"], "scope": "non_contacts"},
|
||||
],
|
||||
)
|
||||
assert out[0]["scope"] == "contacts"
|
||||
assert out[1]["scope"] == "non_contacts"
|
||||
|
||||
|
||||
def test_normalize_invalid_scope_becomes_everyone():
|
||||
out = normalize_lxmf_sieve_filters(
|
||||
[{"action": "ignore", "terms": ["a"], "scope": "unknown"}],
|
||||
)
|
||||
assert out[0]["scope"] == "everyone"
|
||||
|
||||
|
||||
def test_first_match_scope_contacts():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[{"action": "hide", "terms": ["foo"], "scope": "contacts"}],
|
||||
)
|
||||
assert first_matching_lxmf_sieve_rule(rules, "Mr foo", is_contact=False) is None
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(rules, "Mr foo", is_contact=True)["action"]
|
||||
== "hide"
|
||||
)
|
||||
|
||||
|
||||
def test_first_match_scope_non_contacts():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[{"action": "ignore", "terms": ["foo"], "scope": "non_contacts"}],
|
||||
)
|
||||
assert first_matching_lxmf_sieve_rule(rules, "foo bar", is_contact=True) is None
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(rules, "foo bar", is_contact=False)["action"]
|
||||
== "ignore"
|
||||
)
|
||||
|
||||
|
||||
def test_order_skips_non_matching_scope():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{"action": "ignore", "terms": ["spam"], "scope": "contacts"},
|
||||
{"action": "hide", "terms": ["spam"], "scope": "everyone"},
|
||||
],
|
||||
)
|
||||
r = first_matching_lxmf_sieve_rule(rules, "spam here", is_contact=False)
|
||||
assert r["action"] == "hide"
|
||||
|
||||
|
||||
def test_regex_invalid_dropped():
|
||||
assert (
|
||||
normalize_lxmf_sieve_filters(
|
||||
[{"action": "ignore", "terms": ["("], "match_mode": "regex"}],
|
||||
)
|
||||
== []
|
||||
)
|
||||
|
||||
|
||||
def test_regex_matches_peer():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[{"action": "hide", "terms": [r"foo\d+"], "match_mode": "regex"}],
|
||||
)
|
||||
assert first_matching_lxmf_sieve_rule(rules, "x FOO99 y")["action"] == "hide"
|
||||
assert first_matching_lxmf_sieve_rule(rules, "x bar y") is None
|
||||
|
||||
|
||||
def test_message_only_match():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "ignore",
|
||||
"terms": ["alert"],
|
||||
"match_peer_fields": False,
|
||||
"match_message": True,
|
||||
},
|
||||
],
|
||||
)
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
"nothing",
|
||||
message_haystack="my alert here",
|
||||
)["action"]
|
||||
== "ignore"
|
||||
)
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
"alert in peer",
|
||||
message_haystack="no",
|
||||
)
|
||||
is None
|
||||
)
|
||||
|
||||
|
||||
def test_match_message_requires_message_haystack():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "ignore",
|
||||
"terms": ["a"],
|
||||
"match_peer_fields": False,
|
||||
"match_message": True,
|
||||
},
|
||||
],
|
||||
)
|
||||
assert first_matching_lxmf_sieve_rule(rules, "peer", message_haystack=None) is None
|
||||
|
||||
|
||||
def test_peer_and_message_both_must_match_when_enabled():
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "ignore",
|
||||
"terms": ["peerterm", "msgterm"],
|
||||
"match_peer_fields": True,
|
||||
"match_message": True,
|
||||
},
|
||||
],
|
||||
)
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
"has peerterm only",
|
||||
message_haystack="nothing",
|
||||
)
|
||||
is None
|
||||
)
|
||||
assert (
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
"has peerterm",
|
||||
message_haystack="and msgterm here",
|
||||
)["action"]
|
||||
== "ignore"
|
||||
)
|
||||
|
||||
|
||||
def test_banish_action_normalized():
|
||||
rules = normalize_lxmf_sieve_filters([{"action": "banish", "terms": ["x"]}])
|
||||
assert rules[0]["action"] == "banish"
|
||||
102
tests/backend/test_lxmf_sieve_fuzz.py
Normal file
102
tests/backend/test_lxmf_sieve_fuzz.py
Normal file
@@ -0,0 +1,102 @@
|
||||
# SPDX-License-Identifier: 0BSD
|
||||
|
||||
import json
|
||||
|
||||
from hypothesis import given, settings, strategies as st
|
||||
|
||||
from meshchatx.src.backend.lxmf_sieve import (
|
||||
first_matching_lxmf_sieve_rule,
|
||||
normalize_lxmf_sieve_filters,
|
||||
parse_lxmf_sieve_filters_json,
|
||||
)
|
||||
|
||||
_json_like = st.recursive(
|
||||
st.none()
|
||||
| st.booleans()
|
||||
| st.integers(min_value=-10_000, max_value=10_000)
|
||||
| st.floats(allow_nan=False, width=32)
|
||||
| st.text(max_size=256),
|
||||
lambda children: (
|
||||
st.lists(children, max_size=12)
|
||||
| st.dictionaries(st.text(max_size=32), children, max_size=12)
|
||||
),
|
||||
max_leaves=40,
|
||||
)
|
||||
|
||||
|
||||
@given(_json_like)
|
||||
@settings(max_examples=300, deadline=None)
|
||||
def test_normalize_lxmf_sieve_filters_never_raises(data):
|
||||
if isinstance(data, list):
|
||||
normalize_lxmf_sieve_filters(data)
|
||||
else:
|
||||
normalize_lxmf_sieve_filters([data])
|
||||
|
||||
|
||||
@given(st.text(max_size=4096))
|
||||
@settings(max_examples=400, deadline=None)
|
||||
def test_parse_lxmf_sieve_filters_json_never_raises(s):
|
||||
parse_lxmf_sieve_filters_json(s)
|
||||
|
||||
|
||||
@given(st.text(max_size=4096))
|
||||
@settings(max_examples=200, deadline=None)
|
||||
def test_parse_json_dumped_list_never_raises(s):
|
||||
try:
|
||||
payload = json.dumps(
|
||||
[{"action": "ignore", "terms": [s], "match_mode": "substring"}]
|
||||
)
|
||||
except (TypeError, ValueError):
|
||||
return
|
||||
parse_lxmf_sieve_filters_json(payload)
|
||||
|
||||
|
||||
@given(
|
||||
peer=st.text(max_size=512),
|
||||
msg=st.one_of(st.none(), st.text(max_size=512)),
|
||||
is_contact=st.booleans(),
|
||||
raw_terms=st.lists(st.text(max_size=64), max_size=8),
|
||||
)
|
||||
@settings(max_examples=250, deadline=None)
|
||||
def test_first_matching_never_raises(peer, msg, is_contact, raw_terms):
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "ignore",
|
||||
"terms": raw_terms or ["x"],
|
||||
"match_peer_fields": True,
|
||||
"match_message": False,
|
||||
},
|
||||
],
|
||||
)
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
peer,
|
||||
is_contact=is_contact,
|
||||
message_haystack=msg,
|
||||
)
|
||||
|
||||
|
||||
@given(
|
||||
peer=st.text(max_size=256),
|
||||
msg=st.text(max_size=256),
|
||||
is_contact=st.booleans(),
|
||||
)
|
||||
@settings(max_examples=200, deadline=None)
|
||||
def test_first_matching_with_message_flag_never_raises(peer, msg, is_contact):
|
||||
rules = normalize_lxmf_sieve_filters(
|
||||
[
|
||||
{
|
||||
"action": "hide",
|
||||
"terms": ["a"],
|
||||
"match_peer_fields": False,
|
||||
"match_message": True,
|
||||
},
|
||||
],
|
||||
)
|
||||
first_matching_lxmf_sieve_rule(
|
||||
rules,
|
||||
peer,
|
||||
is_contact=is_contact,
|
||||
message_haystack=msg,
|
||||
)
|
||||
Reference in New Issue
Block a user