dandri/MeshChatX
1
0
Fork 0
mirror of https://git.quad4.io/RNS-Things/MeshChatX.git synced 2026-05-11 07:26:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(App.vue): implement polling guard to prevent overlapping updates and ensure proper state management

Browse Source
This commit is contained in:
Ivan
2026-05-02 22:49:21 -05:00
parent 2eff200567
commit fdbe84e877
2 changed files with 39 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
meshchatx/src/frontend/components/App.vue
+38 -25
View File
@@ -811,6 +811,8 @@ export default {
clearInterval(this._propagationSyncPollTimer);
this._propagationSyncPollTimer = null;
}
// Clear polling guard flag on unmount
this._isPropagationSyncPolling = false;
this.stopShell();
this.clearWsShellUiTimers();
if (this.endedTimeout) clearTimeout(this.endedTimeout);
@@ -1498,32 +1500,41 @@ export default {
await this.updatePropagationNodeStatus();
// Guard to prevent overlapping poll calls
this._isPropagationSyncPolling = false;
const poll = async () => {
await this.updatePropagationNodeStatus();
if (this.isSyncingPropagationNode) {
ToastUtils.loading(this.propagationSyncLiveToastMessage(), 0, propagationSyncToastKey);
return;
}
if (this._propagationSyncPollTimer != null) {
clearInterval(this._propagationSyncPollTimer);
this._propagationSyncPollTimer = null;
}
ToastUtils.dismiss(propagationSyncToastKey);
const status = this.propagationNodeStatus?.state;
const messagesReceived = this.propagationNodeStatus?.messages_received ?? 0;
const messagesStored = this.propagationNodeStatus?.messages_stored ?? 0;
const deliveryConfirmations = this.propagationNodeStatus?.delivery_confirmations ?? 0;
const messagesHidden = this.propagationNodeStatus?.messages_hidden ?? 0;
if (status === "complete" || status === "idle") {
const base = this.$t("app.sync_complete", { count: messagesReceived });
const details = `${messagesStored} stored, ${deliveryConfirmations} confirmations, ${messagesHidden} hidden`;
ToastUtils.success(`${base} (${details})`);
} else {
ToastUtils.error(
this.$t("app.sync_error", {
status: this.propagationSyncStatusLabel(status),
})
);
if (this._isPropagationSyncPolling) return;
this._isPropagationSyncPolling = true;
try {
await this.updatePropagationNodeStatus();
if (this.isSyncingPropagationNode) {
ToastUtils.loading(this.propagationSyncLiveToastMessage(), 0, propagationSyncToastKey);
return;
}
if (this._propagationSyncPollTimer != null) {
clearInterval(this._propagationSyncPollTimer);
this._propagationSyncPollTimer = null;
}
ToastUtils.dismiss(propagationSyncToastKey);
const status = this.propagationNodeStatus?.state;
const messagesReceived = this.propagationNodeStatus?.messages_received ?? 0;
const messagesStored = this.propagationNodeStatus?.messages_stored ?? 0;
const deliveryConfirmations = this.propagationNodeStatus?.delivery_confirmations ?? 0;
const messagesHidden = this.propagationNodeStatus?.messages_hidden ?? 0;
if (status === "complete" || status === "idle") {
const base = this.$t("app.sync_complete", { count: messagesReceived });
const details = `${messagesStored} stored, ${deliveryConfirmations} confirmations, ${messagesHidden} hidden`;
ToastUtils.success(`${base} (${details})`);
} else {
ToastUtils.error(
this.$t("app.sync_error", {
status: this.propagationSyncStatusLabel(status),
})
);
}
} finally {
this._isPropagationSyncPolling = false;
}
};
@@ -1560,6 +1571,8 @@ export default {
clearInterval(this._propagationSyncPollTimer);
this._propagationSyncPollTimer = null;
}
// Clear the polling guard flag
this._isPropagationSyncPolling = false;
ToastUtils.dismiss(propagationSyncToastKey);
await this.updatePropagationNodeStatus();
},
tests/frontend/AppPropagationSync.test.js
+1
View File
@@ -27,6 +27,7 @@ function makeSyncContext(axiosMock, tOverrides = {}) {
},
propagationNodeStatus: null,
_propagationSyncPollTimer: null,
_isPropagationSyncPolling: false,
propagationSyncLiveToastMessage: App.methods.propagationSyncLiveToastMessage,
propagationSyncStatusLabel: App.methods.propagationSyncStatusLabel,
get isSyncingPropagationNode() {